You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/07/07 20:37:43 UTC

[GitHub] [beam] ibzib commented on a change in pull request #15119: [BEAM-10955] Revert f077ba51cb0790c403297833d5378b399b7248df

ibzib commented on a change in pull request #15119:
URL: https://github.com/apache/beam/pull/15119#discussion_r665690219



##########
File path: runners/flink/src/test/java/org/apache/beam/runners/flink/FlinkSavepointTest.java
##########
@@ -191,7 +193,7 @@ private void runSavepointAndRestore(boolean isPortablePipeline) throws Exception
   private JobID executeLegacy(Pipeline pipeline) throws Exception {
     JobGraph jobGraph = getJobGraph(pipeline);
     flinkCluster.submitJob(jobGraph).get();
-    return waitForJobToBeReady();
+    return jobGraph.getJobID();

Review comment:
       Why should we revert this line? I think it was a good change, even if it didn't fix the flake.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org