You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "saiswapnilar-stripe (via GitHub)" <gi...@apache.org> on 2026/02/02 21:35:13 UTC
[PR] Adds a broker endpoint to validate query parsing without further validation/execution [pinot]
saiswapnilar-stripe opened a new pull request, #17618:
URL: https://github.com/apache/pinot/pull/17618
Addresses https://github.com/apache/pinot/issues/17615 , adding a broker API endpoint that parses a query string only for syntactic validation without further processing
### Testing
Tested the endpoint by running valid/invalid queries
Valid query: `curl -X POST "localhost:8000/query/sql/validate" \
-H "Content-Type: application/json" \
-d '{"sql": "SELECT * FROM meetupRsvp LIMIT 10"}'`
Result: `{"errorCode":null,"validQuery":true,"errorMessage":null}`
Valid query (non existent table): `curl -X POST "localhost:8000/query/sql/validate" \
-H "Content-Type: application/json" \
-d '{"sql": "SELECT * FROM xyz LIMIT 10"}'`
Result: `{"errorCode":null,"validQuery":true,"errorMessage":null}`
Invalid query (reserved keyword): `curl -X POST "localhost:8000/query/sql/validate" \
-H "Content-Type: application/json" \
-d '{
"sql": "SELECT select FROM airlineStats a JOIN airports b ON a.destAirportCode = b.airportCode"
}'`
Result: `{"errorCode":"SQL_PARSING","validQuery":false,"errorMessage":"Caught exception while parsing query: SELECT select FROM airlineStats a JOIN airports b ON a.destAirportCode = b.airportCode: Encountered \"\" at line 1, column 8.\nWas expecting one of:\n "}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Adds a broker endpoint to validate query parsing without further validation/execution [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17618:
URL: https://github.com/apache/pinot/pull/17618#issuecomment-3837852872
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/17618?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 55.48%. Comparing base ([`36ac509`](https://app.codecov.io/gh/apache/pinot/commit/36ac509f8f61a4712548d7781c9f87360b9232ee?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`809114f`](https://app.codecov.io/gh/apache/pinot/commit/809114f3ec5752677d678e020bd9705da2c4c614?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (36ac509) and HEAD (809114f). Click for more details.
>
> <details><summary>HEAD has 32 uploads less than BASE</summary>
>
>| Flag | BASE (36ac509) | HEAD (809114f) |
>|------|------|------|
>|java-21|5|1|
>|unittests1|2|1|
>|unittests|4|1|
>|temurin|9|1|
>|java-11|4|0|
>|unittests2|2|0|
>|integration|5|0|
>|integration2|1|0|
>|integration1|2|0|
>|custom-integration1|2|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17618 +/- ##
============================================
- Coverage 63.18% 55.48% -7.71%
+ Complexity 1479 702 -777
============================================
Files 3173 2474 -699
Lines 189917 140070 -49847
Branches 29064 22333 -6731
============================================
- Hits 120002 77713 -42289
+ Misses 60575 55781 -4794
+ Partials 9340 6576 -2764
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/17618/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/17618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/17618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/17618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/17618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/17618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/17618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.48% <ø> (-7.65%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/17618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.48% <ø> (-7.71%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/17618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.48% <ø> (-7.71%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/17618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.48% <ø> (-0.02%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/17618/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/17618?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Adds a broker endpoint to validate query parsing without further validation/execution [pinot]
Posted by "saiswapnilar-stripe (via GitHub)" <gi...@apache.org>.
saiswapnilar-stripe closed pull request #17618: Adds a broker endpoint to validate query parsing without further validation/execution
URL: https://github.com/apache/pinot/pull/17618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Adds a broker endpoint to validate query parsing without further validation/execution [pinot]
Posted by "saiswapnilar-stripe (via GitHub)" <gi...@apache.org>.
saiswapnilar-stripe closed pull request #17618: Adds a broker endpoint to validate query parsing without further validation/execution
URL: https://github.com/apache/pinot/pull/17618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org