You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by upthewaterspout <gi...@git.apache.org> on 2017/05/03 17:22:07 UTC
[GitHub] geode pull request #489: GEODE-1728: Http session filter should only apply t...
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/489
GEODE-1728: Http session filter should only apply to REQUEST
The docs should not tell users to add apply the session filter to
FORWARD, INCLUDE, and ERROR dispatchers. It should just be the default,
REQUEST.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/upthewaterspout/incubator-geode feature/GEODE-1728
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/489.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #489
----
commit ce634f4ab194bf378a8890ed1f3069396e8ce72a
Author: Dan Smith <up...@apache.org>
Date: 2017-05-03T17:16:41Z
GEODE-1728: Http session filter should not be applied to FORWARDS
The docs should not tell users to add apply the session filter to
FORWARD, INCLUDE, and ERROR dispatchers. It should just be the default,
REQUEST.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #489: GEODE-1728: Http session filter should only apply t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/489
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #489: GEODE-1728: Http session filter should only apply to REQUE...
Posted by joeymcallister <gi...@git.apache.org>.
Github user joeymcallister commented on the issue:
https://github.com/apache/geode/pull/489
+1 LGTM, Dan. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #489: GEODE-1728: Http session filter should only apply to REQUE...
Posted by upthewaterspout <gi...@git.apache.org>.
Github user upthewaterspout commented on the issue:
https://github.com/apache/geode/pull/489
@joeymcallister @davebarnes97 - can you review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---