You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "zhengziyi0117 (via GitHub)" <gi...@apache.org> on 2024/12/09 08:37:43 UTC
[PR] Update Async Profiler doc [skywalking]
zhengziyi0117 opened a new pull request, #12842:
URL: https://github.com/apache/skywalking/pull/12842
<!--
β οΈ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist π ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== π Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ==== -->
<!-- ==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Async Profiler doc [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #12842:
URL: https://github.com/apache/skywalking/pull/12842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Async Profiler doc [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12842:
URL: https://github.com/apache/skywalking/pull/12842#discussion_r1875581780
##########
docs/menu.yml:
##########
@@ -260,8 +260,8 @@ catalog:
path: "/en/setup/backend/backend-ebpf-profiling"
- name: "Continuous Profiling"
path: "/en/setup/backend/backend-continuous-profiling"
- - name: "Async Profiler"
- path: "/en/setup/backend/backend-async-profiler"
+ - name: "Java App Profiling"
+ path: "/en/setup/backend/backend-java-app-profiling"
Review Comment:
FYI, this will break the final doc path. I will update the blog according.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Async Profiler doc [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12842:
URL: https://github.com/apache/skywalking/pull/12842#discussion_r1875581193
##########
docs/en/setup/backend/backend-java-app-profiling.md:
##########
@@ -45,18 +58,18 @@ When the Agent receives a Async Profiler task from OAP, it automatically generat
### Wait the agent to collect data and upload
-At this point, async-profiler will trace the following kinds of events:
+At this point, Async Profiler will trace the events you selected when you created the task:
-1. CPU cycles
-2. Hardware and Software performance counters like cache misses, branch misses, page faults, context switches etc.
-3. Allocations in Java Heap
-4. Contented lock attempts, including both Java object monitors and ReentrantLocks
+1. CPU,WALL,ITIMER,CTIMER: CPU cycles
+2. ALLOC: Allocations in Java Heap
+3. LOCK: Contented lock attempts, including both Java object monitors and ReentrantLocks
-Finally, java agent will upload the jfr file produced by async-profiler to the oap server for online performance analysis.
+Finally, the agent will upload the jfr file produced by Async Profiler to the oap server for online performance analysis.
### Query the profiling task progresses
-Wait for async-profiler to complete data collection and upload successfullyοΌWe can query the execution log of the async-profiler task and the successful and failed instances,which includes the following information:
+Wait for Async Profiler to complete data collection and upload successfully.
+We can query the execution log of the Async Profiler task and the successful and failed instances,which includes the following information:
Review Comment:
```suggestion
We can query the execution logs of the Async Profiler task and the task status, which includes the following information:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org