You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/07 06:43:55 UTC
[GitHub] [inlong] leosanqing opened a new pull request, #5815: [INLONG-5810][Manager] Supplement the workflow event API in the manager client
leosanqing opened a new pull request, #5815:
URL: https://github.com/apache/inlong/pull/5815
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Fixes #5810
### Motivation
Supplement the workflow event API in the manager client
### Modifications
Supplement the workflow event API in the manager client
### Verifying this change
*(Please pick either of the following options)*
- [x] This change is a trivial rework/code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #5815: [INLONG-5810][Manager] Supplement the workflow event API in the manager client
Posted by GitBox <gi...@apache.org>.
healchow merged PR #5815:
URL: https://github.com/apache/inlong/pull/5815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] leosanqing commented on a diff in pull request #5815: [INLONG-5810][Manager] Supplement the workflow event API in the manager client
Posted by GitBox <gi...@apache.org>.
leosanqing commented on code in PR #5815:
URL: https://github.com/apache/inlong/pull/5815#discussion_r970265205
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/ProcessEvent.java:
##########
@@ -15,9 +15,7 @@
* limitations under the License.
*/
-package org.apache.inlong.manager.workflow.event.process;
-
-import org.apache.inlong.manager.workflow.event.WorkflowEvent;
+package org.apache.inlong.manager.common.enums;
Review Comment:
The api cannot use these enums. They can only be extracted to the common module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5815: [INLONG-5810][Manager] Supplement the workflow event API in the manager client
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5815:
URL: https://github.com/apache/inlong/pull/5815#discussion_r966715420
##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/ProcessEvent.java:
##########
@@ -15,9 +15,7 @@
* limitations under the License.
*/
-package org.apache.inlong.manager.workflow.event.process;
-
-import org.apache.inlong.manager.workflow.event.WorkflowEvent;
+package org.apache.inlong.manager.common.enums;
Review Comment:
Excuse me, but why change the package for those classes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #5815: [INLONG-5810][Manager] Supplement the workflow event API in the manager client
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #5815:
URL: https://github.com/apache/inlong/pull/5815#issuecomment-1246307164
@haifxu @ciscozhou PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] ciscozhou commented on pull request #5815: [INLONG-5810][Manager] Supplement the workflow event API in the manager client
Posted by GitBox <gi...@apache.org>.
ciscozhou commented on PR #5815:
URL: https://github.com/apache/inlong/pull/5815#issuecomment-1246875929
> @haifxu @ciscozhou PTAL, thanks.
OK, I checked and give my +1 to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org