You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/12 11:17:17 UTC

[GitHub] [apisix-ingress-controller] fatpa opened a new issue, #1516: bug: prometheus prefer_name param should be supported to set in apisixclusterconfig

fatpa opened a new issue, #1516:
URL: https://github.com/apache/apisix-ingress-controller/issues/1516

   ### Issue description
   
   Even if I set the `prefer_name: true` at apisix-helm-chart/values.yaml `pluginAttrs` or configmap `apisix` directly, it doesn't work. Because the default apisixclusterconfig will override it and make the change invalid. And the apisixclusterconfig can't support setting `prefer_name` param.
   
   I will add the `prefer_name` param into apisixclusterconfig `prometheusPluginConfig` soon.
   
   ### Environment
   
   - your apisix-ingress-controller version (output of apisix-ingress-controller version --long): 1.5.0
   - your Kubernetes cluster version (output of kubectl version): 1.19.6
   - if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (uname -a): 3.10
   
   
   ### Minimal test code / Steps to reproduce
   
   Nothing
   
   ### Actual result
   
   prefer_name: false
   
   ### Error log
   
   Nothing
   
   ### Expected result
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1516: bug: prometheus prefer_name param should be supported to set in apisixclusterconfig

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #1516:
URL: https://github.com/apache/apisix-ingress-controller/issues/1516#issuecomment-1347998989

   Please wait.
   I don't fully understand what you mean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] fatpa commented on issue #1516: bug: prometheus prefer_name param should be supported to set in apisixclusterconfig

Posted by GitBox <gi...@apache.org>.
fatpa commented on issue #1516:
URL: https://github.com/apache/apisix-ingress-controller/issues/1516#issuecomment-1346305148

   I will add the `prefer_name` param into apisixclusterconfig `prometheusPluginConfig` soon.
   
   Assign it to me plz.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1516: bug: prometheus prefer_name param should be supported to set in apisixclusterconfig

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #1516:
URL: https://github.com/apache/apisix-ingress-controller/issues/1516#issuecomment-1348014732

   you want to add `perfer_name` to `prometheus.properties` ,right?
   
   https://github.com/apache/apisix-ingress-controller/blob/master/samples/deploy/crd/v1/ApisixClusterConfig.yaml#L58-L62


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] fatpa commented on issue #1516: feat request: prometheus prefer_name param should be supported to set in apisixclusterconfig

Posted by GitBox <gi...@apache.org>.
fatpa commented on issue #1516:
URL: https://github.com/apache/apisix-ingress-controller/issues/1516#issuecomment-1348017593

   > you want to add `perfer_name` to `prometheus.properties` ,right?
   > 
   > https://github.com/apache/apisix-ingress-controller/blob/master/samples/deploy/crd/v1/ApisixClusterConfig.yaml#L58-L62
   
   yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] fatpa commented on issue #1516: feat request: prometheus prefer_name param should be supported to set in apisixclusterconfig

Posted by GitBox <gi...@apache.org>.
fatpa commented on issue #1516:
URL: https://github.com/apache/apisix-ingress-controller/issues/1516#issuecomment-1348020038

   > https://github.com/apache/apisix-ingress-controller/blob/master/samples/deploy/crd/v1/ApisixClusterConfig.yaml#L58-L62
   
   And I already finish it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #1516: feat request: prometheus prefer_name param should be supported to set in apisixclusterconfig

Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 closed issue #1516: feat request: prometheus prefer_name param should be supported to set in apisixclusterconfig
URL: https://github.com/apache/apisix-ingress-controller/issues/1516


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org