You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/06/06 09:36:25 UTC
[GitHub] [incubator-doris] kangkaisen opened a new pull request #3793: Fix largeint max min bug
kangkaisen opened a new pull request #3793:
URL: https://github.com/apache/incubator-doris/pull/3793
For #3792
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen merged pull request #3793: Fix largeint max min bug
Posted by GitBox <gi...@apache.org>.
kangkaisen merged pull request #3793:
URL: https://github.com/apache/incubator-doris/pull/3793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3793: Fix largeint max min bug
Posted by GitBox <gi...@apache.org>.
chaoyli commented on a change in pull request #3793:
URL: https://github.com/apache/incubator-doris/pull/3793#discussion_r436418867
##########
File path: be/src/exprs/expr_value.h
##########
@@ -177,7 +177,7 @@ struct ExprValue {
return &bigint_val;
case TYPE_LARGEINT:
- large_int_val = 0;
+ large_int_val = std::numeric_limits<int128_t>::min();
Review comment:
I have a question.
Does std::numeric_limits supports int128_t?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3793: Fix largeint max min bug
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #3793:
URL: https://github.com/apache/incubator-doris/pull/3793#discussion_r436424892
##########
File path: be/src/exprs/expr_value.h
##########
@@ -177,7 +177,7 @@ struct ExprValue {
return &bigint_val;
case TYPE_LARGEINT:
- large_int_val = 0;
+ large_int_val = std::numeric_limits<int128_t>::min();
Review comment:
Yes. It does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org