You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2018/05/11 17:47:56 UTC
Re: Review Request 66650: Removed an invalid TODO in puller.cpp.
> On April 17, 2018, 6:33 p.m., Qian Zhang wrote:
> > Mind to explain why this TODO is invalid in the description? :-)
It means registry per container I believe. We already support registry prefix like quay.io/alpine:lastest
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66650/#review201368
-----------------------------------------------------------
On April 16, 2018, 10:32 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66650/
> -----------------------------------------------------------
>
> (Updated April 16, 2018, 10:32 p.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-8794
> https://issues.apache.org/jira/browse/MESOS-8794
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed an invalid TODO in puller.cpp.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/docker/puller.cpp d7d8987d493a37d20f32ddd254dc0c3b15159951
>
>
> Diff: https://reviews.apache.org/r/66650/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>