You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by taishi-oss <gi...@git.apache.org> on 2015/09/29 09:02:35 UTC
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
GitHub user taishi-oss opened a pull request:
https://github.com/apache/spark/pull/8935
[SPARK-10263] [ML] Add @Since annotation to ml.param and ml.*
Add Since annotations to ml.param and ml.*
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/taishi-oss/spark issue10263
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8935.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8935
----
commit 862d67083dc123c231b1795e0e0f8f0eb537946d
Author: Takahashi Hiroshi <ta...@lab.ntt.co.jp>
Date: 2015-09-29T07:03:45Z
Add @Since annotations
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by taishi-oss <gi...@git.apache.org>.
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-153615685
Sorry for being late.
I rebased this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by yu-iskw <gi...@git.apache.org>.
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-152881784
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by taishi-oss <gi...@git.apache.org>.
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-161544658
in Pipeline.scala, I have some questions.
1.
for example, Pipeline.fit was introduced in v1.2.0.
but, signature was changed in v1.4.0
```
v1.2.0: def fit(dataset: SchemaRDD, paramMap: ParamMap): PipelineModel
v1.4.0: fit(dataset: DataFrame): PipelineModel
```
Which should I choose?
There are some methods of which signature is changed.
for the present, I choose old version.
2.
"class PipelineModel"'s public valiable "stages" is private until v.1.4.0 but is public since v.1.4.0.
```
hiro [spark] (master) > git show v1.2.0:mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala | grep "val stages: Array\[Transformer\]"
private[ml] val stages: Array[Transformer])
hiro [spark] (master) > git show v1.3.0:mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala | grep "val stages: Array\[Transformer\]"
private[ml] val stages: Array[Transformer])
hiro [spark] (master) > git show v1.4.0:mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala | grep "val stages: Array\[Transformer\]"
val stages: Array[Transformer])
```
I choose v.1.4.0 but I think v1.2.0 is also collect.
which should I choose?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by taishi-oss <gi...@git.apache.org>.
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-144666719
@mengxr Could you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173033564
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49715/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by yu-iskw <gi...@git.apache.org>.
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-152026373
Sure!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173335649
**[Test build #49798 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49798/consoleFull)** for PR 8935 at commit [`06a5272`](https://github.com/apache/spark/commit/06a5272622e27056936f1c2dee40546dc945016d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class Pipeline @Since(\"1.4.0\") (`
* `case class ParamPair[T] @Since(\"1.2.0\") (`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by yu-iskw <gi...@git.apache.org>.
Github user yu-iskw commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-152027157
@hiross sorry for the delay of my response. Can you rebase your branch? It seems that there are any conflicts with the master. So, we can't merge your PR with the master cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by taishi-oss <gi...@git.apache.org>.
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-167196430
I modified some mistakes that was pointed out in #8534.
@mengxr Could you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by taishi-oss <gi...@git.apache.org>.
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-161544578
@yu-iskw Sorry for being late, I modify my miss and add anotation to all public class, object, methods, and variables.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173335838
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49798/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173007455
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173335836
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173337365
Merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by taishi-oss <gi...@git.apache.org>.
Github user taishi-oss commented on a diff in the pull request:
https://github.com/apache/spark/pull/8935#discussion_r46520868
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -82,8 +82,11 @@ abstract class PipelineStage extends Params with Logging {
* an identity transformer.
*/
@Experimental
-class Pipeline(override val uid: String) extends Estimator[PipelineModel] {
+@Since("1.5.0")
+class Pipeline(
+ @Since("1.5.0") override val uid: String) extends Estimator[PipelineModel] {
+ @Since("1.5.0")
--- End diff --
"git show" says Pipeline.this was introduced in v1.4.0.
```
hiro [spark] (master) > git show v1.2.0:mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala | grep "def this"
hiro [spark] (master) > git show v1.3.0:mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala | grep "def this"
hiro [spark] (master) > git show v1.4.0:mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala | grep "def this"
def this() = this(Identifiable.randomUID("pipeline"))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by taishi-oss <gi...@git.apache.org>.
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173107263
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8935#discussion_r43084417
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -82,8 +82,11 @@ abstract class PipelineStage extends Params with Logging {
* an identity transformer.
*/
@Experimental
-class Pipeline(override val uid: String) extends Estimator[PipelineModel] {
+@Since("1.5.0")
--- End diff --
`Pipeline` was introduced in 1.2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8935#discussion_r43084419
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -82,8 +82,11 @@ abstract class PipelineStage extends Params with Logging {
* an identity transformer.
*/
@Experimental
-class Pipeline(override val uid: String) extends Estimator[PipelineModel] {
+@Since("1.5.0")
+class Pipeline(
+ @Since("1.5.0") override val uid: String) extends Estimator[PipelineModel] {
+ @Since("1.5.0")
--- End diff --
This is since 1.2 as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173322151
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173007683
LGTM pending Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by taishi-oss <gi...@git.apache.org>.
Github user taishi-oss commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173420746
Thank you for merging!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173033563
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8935
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173033439
**[Test build #49715 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49715/consoleFull)** for PR 8935 at commit [`06a5272`](https://github.com/apache/spark/commit/06a5272622e27056936f1c2dee40546dc945016d).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class Pipeline @Since(\"1.4.0\") (`
* `case class ParamPair[T] @Since(\"1.2.0\") (`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-151376098
@hiross Sorry for my slow response! Please check the public API instead of line changes. The former is more accurate. The PR has merge conflicts with the master branch. Could you merge current master and resolve conflicts? Thanks!
@yu-iskw Could you help review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-144101800
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173010615
**[Test build #49715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49715/consoleFull)** for PR 8935 at commit [`06a5272`](https://github.com/apache/spark/commit/06a5272622e27056936f1c2dee40546dc945016d).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8935#issuecomment-173324227
**[Test build #49798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49798/consoleFull)** for PR 8935 at commit [`06a5272`](https://github.com/apache/spark/commit/06a5272622e27056936f1c2dee40546dc945016d).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...
Posted by mengxr <gi...@git.apache.org>.
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8935#discussion_r43084418
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -82,8 +82,11 @@ abstract class PipelineStage extends Params with Logging {
* an identity transformer.
*/
@Experimental
-class Pipeline(override val uid: String) extends Estimator[PipelineModel] {
+@Since("1.5.0")
+class Pipeline(
+ @Since("1.5.0") override val uid: String) extends Estimator[PipelineModel] {
--- End diff --
`uid` should be since 1.4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org