[GitHub] [spark] rxin commented on issue #24117: [SPARK-27181][SQL]: Add public transform API

[GitBox <gi...@apache.org>]

rxin commented on issue #24117: [SPARK-27181][SQL]: Add public transform API
URL: https://github.com/apache/spark/pull/24117#issuecomment-483459273
 
 
   Can we create a JIRA ticket and mark it a blocker for 3.0? It'd be bad to move all classes after 3.0.
   
   On Mon, Apr 15, 2019 at 4:48 PM, Ryan Blue < notifications@github.com > wrote:
   
   > 
   > 
   > 
   > *@rdblue* commented on this pull request.
   > 
   > 
   > 
   > In sql/ catalyst/ src/ main/ java/ org/ apache/ spark/ sql/ catalog/ v2/ expressions/
   > Expression. java (
   > https://github.com/apache/spark/pull/24117#discussion_r275584382 ) :
   > 
   > > + * contributor license agreements. See the NOTICE file distributed with
   > + * this work for additional information regarding copyright ownership. +
   > * The ASF licenses this file to You under the Apache License, Version 2.0
   > + * (the "License"); you may not use this file except in compliance with +
   > * the License. You may obtain a copy of the License at + * + * http:/ / www.
   > apache. org/ licenses/ LICENSE-2. 0 (
   > http://www.apache.org/licenses/LICENSE-2.0 ) + * + * Unless required by
   > applicable law or agreed to in writing, software + * distributed under the
   > License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR
   > CONDITIONS OF ANY KIND, either express or implied. + * See the License for
   > the specific language governing permissions and + * limitations under the
   > License. + */ + +package org.apache.spark.sql.catalog.v2.expressions;
   > 
   > First, we have to decide on what all we need to move. I don't think that
   > is clear yet. The next concern is getting #24246 (
   > https://github.com/apache/spark/pull/24246 ) in because it is a blocker for
   > a lot of work that can be done in parallel. After that, it would be nice
   > to coordinate to avoid breaking lots of PRs, but that's less of a concern.
   > 
   > 
   > 
   > 
   > So to answer your question, I think we should do this after #24246 (
   > https://github.com/apache/spark/pull/24246 ) and after we've decided what
   > needs to move and what the new organization should be.
   > 
   > 
   > 
   > The actual changes should be simple and quick to review, but would cause
   > too much delay combined into a PR with other changes.
   > 
   > 
   > 
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub (
   > https://github.com/apache/spark/pull/24117#discussion_r275584382 ) , or mute
   > the thread (
   > https://github.com/notifications/unsubscribe-auth/AATvPPrGVn_d-wMJ-FpQfWH0ySYnFrS6ks5vhQ-xgaJpZM4b4GN3
   > ).
   > 
   > 
   >

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org