[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common
URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r318840944
 
 

 ##########
 File path: superset/common/query_context.py
 ##########
 @@ -150,8 +155,8 @@ def cache_timeout(self):
             return self.datasource.database.cache_timeout
         return config.get("CACHE_DEFAULT_TIMEOUT")
 
 Review comment:
   either you need to add a default value to the `get` call or return `config["CACHE_DEFAULT_TIMEOUT"]` otherwise this could return None

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org