You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2026/07/16 15:53:10 UTC

[PR] Don't fail API server startup when a plugin uses an unknown team [airflow]

pierrejeambrun opened a new pull request, #69976:
URL: https://github.com/apache/airflow/pull/69976

   Follow-up of #69502.
   
   #69502 added team validation for plugins, but a single plugin referencing a team that does not exist raised during app creation — so the whole API server, and every other plugin, failed to boot. A misconfigured plugin should be surfaced, not fatal, the same way other plugin load errors are.
   
   The team check now records each offending plugin as a **plugin import error** (surfaced in the plugins API and UI, like any other plugin load failure) and logs a warning instead of raising. It also runs from `get_fastapi_plugins()` — which `init_plugins()` already calls — so validation happens automatically wherever plugins are mounted, rather than relying on a separate `validate_plugin_teams()` call that a caller could forget.
   
   Only reached from the API server and the `airflow plugins` CLI (never workers/dag-processor/triggerer), and the DB is only touched when `[core] multi_team` is enabled.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 4.8)
   
   Generated-by: Claude Code (Opus 4.8) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Don't fail API server startup when a plugin uses an unknown team [airflow]

Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on PR #69976:
URL: https://github.com/apache/airflow/pull/69976#issuecomment-4997951010

   Hey, thanks for the PR @pierrejeambrun we definitely talked about this and @vincbeck will be happy you decided to change this :smile: 
   
   Many other components in Airflow fail to start if things are misconfigured (related to teams and otherwise). So the thinking was the user will have to restart the API server anyway and we should not start in a bad state. I hear the reasoning that it's just a plugin and it's fine to start in that failed state. The plan was to see how users feel about it and pivot if needed :slightly_smiling_face:   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Don't fail API server startup when a plugin uses an unknown team [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #69976:
URL: https://github.com/apache/airflow/pull/69976#issuecomment-4993924192

   cc: @vincbeck @o-nikolas 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Don't fail API server startup when a plugin uses an unknown team [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #69976:
URL: https://github.com/apache/airflow/pull/69976


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org