You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Beyyes (via GitHub)" <gi...@apache.org> on 2023/01/30 08:59:04 UTC
[GitHub] [iotdb] Beyyes commented on a diff in pull request #8919: [IOTDB-5419] Add Region status in DataNode Heartbeat
Beyyes commented on code in PR #8919:
URL: https://github.com/apache/iotdb/pull/8919#discussion_r1090322101
##########
confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/DataNodeRemoveHandler.java:
##########
@@ -155,6 +157,39 @@ public TDataNodeLocation findDestDataNode(TConsensusGroupId regionId) {
return newNode.get();
}
+ public TSStatus setRegionStatus(TConsensusGroupId regionId, TDataNodeLocation originalDataNode) {
Review Comment:
```suggestion
public TSStatus setRegionStatusAsRemoving(TConsensusGroupId regionId, TDataNodeLocation originalDataNode) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org