You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Olivier Lamy (Jira)" <ji...@apache.org> on 2022/02/26 00:16:00 UTC
[jira] [Reopened] (SUREFIRE-1681) Don't ignore errors while using maven.test.failure.ignore
[ https://issues.apache.org/jira/browse/SUREFIRE-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy reopened SUREFIRE-1681:
------------------------------------
still a problem
> Don't ignore errors while using maven.test.failure.ignore
> ---------------------------------------------------------
>
> Key: SUREFIRE-1681
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1681
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
> Affects Versions: 3.0.0-M3
> Reporter: Josef Cacek
> Assignee: Tibor Digana
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This is a follow up for SUREFIRE-1426.
> Surefire should only ignore test failures when SurefirePlugin.testFailureIgnore property is set to true (as the name suggests). Test errors should not be ignored.
> If the forked JVM crashes during the test, then TEST-*.xml report file is not created, so the user will miss the problem when he evaluates test reports afterward (e.g. in Jenkins).
> The code of SurefireHelper.report execution could be improved to verify the error count:
> {code:java}
> if ( reportParameters.isTestFailureIgnore() && result.getErrors() == 0 )
> {
> log.error( createErrorMessage( reportParameters, result, firstForkException ) );
> }
> {code}
> instead of simply ignoring all problems as it's now:
> {code:java}
> if ( reportParameters.isTestFailureIgnore() )
> {
> log.error( createErrorMessage( reportParameters, result, firstForkException ) );
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)