[GitHub] qpid-proton issue #74: proton-j : Upgrade BouncyCastle

[gemmellr <gi...@git.apache.org>]

Github user gemmellr commented on the issue:

    https://github.com/apache/qpid-proton/pull/74
  
    The CI builds are failing while running the cmake build (using it is outlined in DEVELOPERS.md) rather than the maven build. The cmake build creates a proton-j jar by itself for use in certain tests, a process which these changes break through introduction of a compile time dependency on bouncycastle that it doesn't accommodate because it didn't previously need to. Either the update needs to be made fully-reflective as before, or the cmake build updated to accommodate the new compilation dependency.
    
    Some more general comments:
    - The main module and tests are specifying difference versions of bouncycastle to use.
    - If you include the JIRA title in the PR title, it will be updated by a bot upon PR open/comments/close.
    - Please reference the JIRA in commit msg, i.e "PROTON-XYZ: msg".
    - Please remove merge commits from PRs.
    
    (Mentioning PROTON-1224 so it also gets updated)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org