[GitHub] [airflow] casra-developers commented on a diff in pull request #29935: Fix for Windows

["casra-developers (via GitHub)" <gi...@apache.org>]

casra-developers commented on code in PR #29935:
URL: https://github.com/apache/airflow/pull/29935#discussion_r1127556476


##########
airflow/jobs/local_task_job.py:
##########
@@ -263,7 +263,7 @@ def heartbeat_callback(self, session=None):
                 recorded_pid = psutil.Process(ti.pid).ppid()
                 same_process = recorded_pid == current_pid
 
-            if recorded_pid is not None and not same_process:
+            if not IS_WINDOWS and recorded_pid is not None and not same_process:

Review Comment:
   The AirflowException will be raised, since the PIDs will never match on Windows. With the patch, Windows workers are able to properly handle tasks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org