[GitHub] [hudi] vinishjail97 commented on a change in pull request #4674: Add default value as null for S3 Incremental source properties

[GitBox <gi...@apache.org>]

vinishjail97 commented on a change in pull request #4674:
URL: https://github.com/apache/hudi/pull/4674#discussion_r790941990



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/S3EventsHoodieIncrSource.java
##########
@@ -125,10 +125,10 @@ public S3EventsHoodieIncrSource(
     if (!StringUtils.isNullOrEmpty(props.getString(Config.S3_KEY_PREFIX))) {
       filter = filter + " and s3.object.key like '" + props.getString(Config.S3_KEY_PREFIX) + "%'";
     }
-    if (!StringUtils.isNullOrEmpty(props.getString(Config.S3_IGNORE_KEY_PREFIX))) {
+    if (!StringUtils.isNullOrEmpty(props.getString(Config.S3_IGNORE_KEY_PREFIX, null))) {

Review comment:
       We need the folder prefix as a required argument I guess right ? Otherwise incremental job will ingest all the files in the bucket. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org