You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mr-git (via GitHub)" <gi...@apache.org> on 2025/05/20 09:08:05 UTC

[D] inmem snapshot store [pekko]

GitHub user mr-git created a discussion: inmem snapshot store

Currently there is a support for in-mem journal, but not for in-mem snapshot store.

https://github.com/alstanchev/pekko-persistence-inmemory provides such support, but as additional library.

Would it be possible to "integrate" the above-mentioned library next to `org.apache.pekko.persistence.journal.inmem.InmemJournal`?

GitHub link: https://github.com/apache/pekko/discussions/1856

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [D] inmem snapshot store [pekko]

Posted by "mr-git (via GitHub)" <gi...@apache.org>.
GitHub user mr-git edited a comment on the discussion: inmem snapshot store

wow, got it working with extra config:
```hocon
# In-memory snapshot-store plugin.
pekko.persistence.snapshot-store.inmem {
  # Class name of the plugin.
  class = "org.apache.pekko.persistence.testkit.PersistenceTestKitSnapshotPlugin"
}
```

so that I can use it in similar fashion as `InmemJournal`:
```hocon
pekko .persistence {
  journal.plugin = "pekko.persistence.journal.inmem"
  snapshot-store.plugin = "pekko.persistence.snapshot-store.inmem"
}
```

IMHO, the first snippet mush be provided by `testkit` in same fashion as Journal's `inmem` is provided.

I guess it was like that in akka too, but current developer experience is sub-optimal

GitHub link: https://github.com/apache/pekko/discussions/1856#discussioncomment-13205833

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [D] inmem snapshot store [pekko]

Posted by "mr-git (via GitHub)" <gi...@apache.org>.
GitHub user mr-git added a comment to the discussion: inmem snapshot store

honestly, I am not sure :( 

in https://pekko.apache.org/docs/pekko/1.1/general/configuration-reference.html#config-pekko-persistence-testkit I cannot find the instruction on how to configure it - there is instruction only for `InmemJournal` usage

GitHub link: https://github.com/apache/pekko/discussions/1856#discussioncomment-13205421

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [D] inmem snapshot store [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
GitHub user pjfanning added a comment to the discussion: inmem snapshot store

I'm aware of that. ASF also require CLAs and SGAs.

GitHub link: https://github.com/apache/pekko/discussions/1856#discussioncomment-13204579

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [D] inmem snapshot store [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
GitHub user pjfanning edited a comment on the discussion: inmem snapshot store

It would be more complicated again if we did have to change the license too - all code contributors would need to agree to the license change.

GitHub link: https://github.com/apache/pekko/discussions/1856#discussioncomment-13204611

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [D] inmem snapshot store [pekko]

Posted by "ptrdom (via GitHub)" <gi...@apache.org>.
GitHub user ptrdom added a comment to the discussion: inmem snapshot store

I guess `persistence-testkit` plugins were implemented after `InmemJournal` and what you need was not considered a user-facing part of the testkit plugins, hence no documentation. Maybe we should reconsider that.

Using the following configs should work:
https://github.com/apache/pekko/blob/f9052401143c8e056c14d1c62e6a695e961b842a/persistence-testkit/src/main/scala/org/apache/pekko/persistence/testkit/PersistenceTestKitPlugin.scala#L127-L130
https://github.com/apache/pekko/blob/f9052401143c8e056c14d1c62e6a695e961b842a/persistence-testkit/src/main/scala/org/apache/pekko/persistence/testkit/PersistenceTestKitPlugin.scala#L179-L184

GitHub link: https://github.com/apache/pekko/discussions/1856#discussioncomment-13205501

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [D] inmem snapshot store [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
GitHub user pjfanning added a comment to the discussion: inmem snapshot store

1. I don't see why there can't be an ecosystem of Pekko community jars and why everything must become part of Apache Pekko
2. If we did agree to take this code over, we would need the code contributors to alstanchev/pekko-persistence-inmemory to agree to it and sign Apache CLAs and possibly also get a Software Grant signed.

GitHub link: https://github.com/apache/pekko/discussions/1856#discussioncomment-13204330

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [D] inmem snapshot store [pekko]

Posted by "ptrdom (via GitHub)" <gi...@apache.org>.
GitHub user ptrdom added a comment to the discussion: inmem snapshot store

`PersistenceTestKitPlugin` and  `PersistenceTestKitSnapshotPlugin` exist in `persistence-testkit` module already, they provide in-memory storage for journal and snapshots, are they insufficient for your use case?

GitHub link: https://github.com/apache/pekko/discussions/1856#discussioncomment-13204659

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [D] inmem snapshot store [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
GitHub user pjfanning added a comment to the discussion: inmem snapshot store

It would be more complicated again if we did have to change the license too.

GitHub link: https://github.com/apache/pekko/discussions/1856#discussioncomment-13204611

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [D] inmem snapshot store [pekko]

Posted by "mr-git (via GitHub)" <gi...@apache.org>.
GitHub user mr-git added a comment to the discussion: inmem snapshot store

https://github.com/alstanchev/pekko-persistence-inmemory?tab=License-1-ov-file - they are using Apache License

GitHub link: https://github.com/apache/pekko/discussions/1856#discussioncomment-13204541

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [D] inmem snapshot store [pekko]

Posted by "mr-git (via GitHub)" <gi...@apache.org>.
GitHub user mr-git added a comment to the discussion: inmem snapshot store

wow, got it working with extra config:
```hocon
# In-memory snapshot-store plugin.
pekko.persistence.snapshot-store.inmem {
  # Class name of the plugin.
  class = "org.apache.pekko.persistence.testkit.PersistenceTestKitSnapshotPlugin"
}
```

so that I can use it similar fashion as `InmemJournal`:
```hocon
pekko .persistence {
  journal.plugin = "pekko.persistence.journal.inmem"
  snapshot-store.plugin = "pekko.persistence.snapshot-store.inmem"
}
```

IMHO, the first snippet mush be provided by `testkit` in same fashion as Journal's `inmem` is provided.

I guess it was like that in akka too, but current developer experience is sub-optimal

GitHub link: https://github.com/apache/pekko/discussions/1856#discussioncomment-13205833

----
This is an automatically sent email for notifications@pekko.apache.org.
To unsubscribe, please send an email to: notifications-unsubscribe@pekko.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org