You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "everpcpc (via GitHub)" <gi...@apache.org> on 2023/10/10 04:36:35 UTC
[PR] chore(ci): publish to pypi with github OIDC credential [incubator-opendal]
everpcpc opened a new pull request, #3252:
URL: https://github.com/apache/incubator-opendal/pull/3252
- fixes: #3251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(ci): publish to pypi with github OIDC credential [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3252:
URL: https://github.com/apache/incubator-opendal/pull/3252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(ci): publish to pypi with github OIDC credential [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3252:
URL: https://github.com/apache/incubator-opendal/pull/3252#discussion_r1351442839
##########
.github/workflows/bindings_python.yml:
##########
@@ -111,15 +111,14 @@ jobs:
name: Release
runs-on: ubuntu-latest
if: "startsWith(github.ref, 'refs/tags/') && !contains(github.ref, '-')"
+ permissions:
+ contents: read
+ id-token: write
needs: [macos, linux, windows]
steps:
- uses: actions/download-artifact@v3
with:
name: wheels
- - name: Publish to PyPI
- uses: PyO3/maturin-action@v1
- env:
- MATURIN_PYPI_TOKEN: ${{ secrets.PYPI_API_TOKEN }}
+ - uses: pypa/gh-action-pypi-publish@release/v1
Review Comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(ci): publish to pypi with github OIDC credential [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3252:
URL: https://github.com/apache/incubator-opendal/pull/3252#discussion_r1351443066
##########
.github/workflows/bindings_python.yml:
##########
@@ -111,15 +111,14 @@ jobs:
name: Release
runs-on: ubuntu-latest
if: "startsWith(github.ref, 'refs/tags/') && !contains(github.ref, '-')"
+ permissions:
+ contents: read
+ id-token: write
needs: [macos, linux, windows]
steps:
- uses: actions/download-artifact@v3
with:
name: wheels
- - name: Publish to PyPI
- uses: PyO3/maturin-action@v1
- env:
- MATURIN_PYPI_TOKEN: ${{ secrets.PYPI_API_TOKEN }}
+ - uses: pypa/gh-action-pypi-publish@release/v1
Review Comment:
Looks good to me, let's go! Thanks for your patience!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(ci): publish to pypi with github OIDC credential [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #3252:
URL: https://github.com/apache/incubator-opendal/pull/3252#discussion_r1351436334
##########
.github/workflows/bindings_python.yml:
##########
@@ -111,15 +111,14 @@ jobs:
name: Release
runs-on: ubuntu-latest
if: "startsWith(github.ref, 'refs/tags/') && !contains(github.ref, '-')"
+ permissions:
+ contents: read
+ id-token: write
needs: [macos, linux, windows]
steps:
- uses: actions/download-artifact@v3
with:
name: wheels
- - name: Publish to PyPI
- uses: PyO3/maturin-action@v1
- env:
- MATURIN_PYPI_TOKEN: ${{ secrets.PYPI_API_TOKEN }}
+ - uses: pypa/gh-action-pypi-publish@release/v1
Review Comment:
I'm not sure if `pypa/gh-action-pypi-publish@release/v1` approved by the ASF. Would like to add a quick demo job that only have `pypa/gh-action-pypi-publish@release/v1`? I expect it to fail instead of skipped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org