svn commit: r1493940 - in /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4: bidimap/ list/ map/

[tn...@apache.org]

Author: tn
Date: Mon Jun 17 21:11:03 2013
New Revision: 1493940

URL: http://svn.apache.org/r1493940
Log:
Remove todos related to privatizing fields -> keep it as is for now.

Modified:
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/bidimap/AbstractDualBidiMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/AbstractLinkedList.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/AbstractHashedMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/AbstractLinkedMap.java
    commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/EntrySetToMapIteratorAdapter.java

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/bidimap/AbstractDualBidiMap.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/bidimap/AbstractDualBidiMap.java?rev=1493940&r1=1493939&r2=1493940&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/bidimap/AbstractDualBidiMap.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/bidimap/AbstractDualBidiMap.java Mon Jun 17 21:11:03 2013
@@ -41,8 +41,6 @@ import org.apache.commons.collections4.k
  */
 public abstract class AbstractDualBidiMap<K, V> implements BidiMap<K, V> {
 
-    // TODO privatise fields?
-
     /**
      * Normal delegate map.
      */

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/AbstractLinkedList.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/AbstractLinkedList.java?rev=1493940&r1=1493939&r2=1493940&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/AbstractLinkedList.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/list/AbstractLinkedList.java Mon Jun 17 21:11:03 2013
@@ -54,8 +54,6 @@ public abstract class AbstractLinkedList
      * - respects {@link AbstractList#modCount}
      */
 
-    // TODO Privatise fields?
-
     /**
      * A {@link Node} which indicates the start and end of the list and does not
      * hold a value. The value of <code>next</code> is the first item in the

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/AbstractHashedMap.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/AbstractHashedMap.java?rev=1493940&r1=1493939&r2=1493940&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/AbstractHashedMap.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/AbstractHashedMap.java Mon Jun 17 21:11:03 2013
@@ -75,8 +75,6 @@ public class AbstractHashedMap<K, V> ext
     /** An object for masking null */
     protected static final Object NULL = new Object();
 
-    // TODO Privatise fields?
-
     /** Load factor, normally 0.75 */
     protected transient float loadFactor;
     /** The size of the map */

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/AbstractLinkedMap.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/AbstractLinkedMap.java?rev=1493940&r1=1493939&r2=1493940&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/AbstractLinkedMap.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/AbstractLinkedMap.java Mon Jun 17 21:11:03 2013
@@ -62,7 +62,7 @@ import org.apache.commons.collections4.i
 public abstract class AbstractLinkedMap<K, V> extends AbstractHashedMap<K, V> implements OrderedMap<K, V> {
 
     /** Header in the linked list */
-    protected transient LinkEntry<K, V> header; // TODO Privatise?
+    protected transient LinkEntry<K, V> header;
 
     /**
      * Constructor only used in deserialization, do not use otherwise.
@@ -501,7 +501,7 @@ public abstract class AbstractLinkedMap<
      */
     protected static class LinkEntry<K, V> extends HashEntry<K, V> {
         /** The entry before this one in the order */
-        protected LinkEntry<K, V> before; // TODO Privatise?
+        protected LinkEntry<K, V> before;
         /** The entry after this one in the order */
         protected LinkEntry<K, V> after;
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/EntrySetToMapIteratorAdapter.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/EntrySetToMapIteratorAdapter.java?rev=1493940&r1=1493939&r2=1493940&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/EntrySetToMapIteratorAdapter.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections4/map/EntrySetToMapIteratorAdapter.java Mon Jun 17 21:11:03 2013
@@ -31,8 +31,6 @@ import org.apache.commons.collections4.R
  */
 public class EntrySetToMapIteratorAdapter<K, V> implements MapIterator<K, V>, ResettableIterator<K> {
 
-    // TODO Privatise fields?
-
     /** The adapted Map entry Set. */
     protected Set<Map.Entry<K, V>> entrySet;