You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Jacques Le Roux (JIRA)" <ji...@apache.org> on 2008/01/28 19:29:37 UTC
[jira] Created: (OFBIZ-1605) You can't replenish a gift card from
eCommerce using the "Gift Card Reload" product (GC-002)
You can't replenish a gift card from eCommerce using the "Gift Card Reload" product (GC-002)
--------------------------------------------------------------------------------------------
Key: OFBIZ-1605
URL: https://issues.apache.org/jira/browse/OFBIZ-1605
Project: OFBiz
Issue Type: Bug
Components: content, ecommerce
Affects Versions: SVN trunk, Release Branch 4.0
Reporter: Jacques Le Roux
Assignee: Jacques Le Roux
Fix For: SVN trunk, Release Branch 4.0
I propose this patch. You can see the thread here http://www.nabble.com/Re%3A-Gift-Card-Number-issue-td15125178.html.
I nobody complains I will commit this patch soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1605) You can't replenish a gift card from
eCommerce using the "Gift Card Reload" product (GC-002)
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-1605.
----------------------------------
Resolution: Fixed
Fixed in trunk rev. 616182 and release4.0 616183
> You can't replenish a gift card from eCommerce using the "Gift Card Reload" product (GC-002)
> --------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1605
> URL: https://issues.apache.org/jira/browse/OFBIZ-1605
> Project: OFBiz
> Issue Type: Bug
> Components: content, ecommerce
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: SurveyServices.xml.patch
>
>
> I propose this patch. You can see the thread here http://www.nabble.com/Re%3A-Gift-Card-Number-issue-td15125178.html.
> I nobody complains I will commit this patch soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1605) You can't replenish a gift card from
eCommerce using the "Gift Card Reload" product (GC-002)
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux updated OFBIZ-1605:
-----------------------------------
Attachment: SurveyServices.xml.patch
I was ready to add a call to a new isFinAccountCode() method from UtilValidate.isGiftCard(). This method could have returned true, if the "number" is a finAccountCode, the finAccountTypeId is GIFTCERT_ACCOUNT and the statusId is FNACT_ACTIVE.
But obviously this is not a place to make a call to the Entity Engine for a FinAccount Entity of the Accounting Application
component.
So I wonder if we should not better make this check in the validateSurveyResponseInline simple-method (in SurveyServices.xml) just before
<if-validate-method field-name="${answerFieldName}" method="isGiftCard">
to bypass this line if the code is of type FinAccount
> You can't replenish a gift card from eCommerce using the "Gift Card Reload" product (GC-002)
> --------------------------------------------------------------------------------------------
>
> Key: OFBIZ-1605
> URL: https://issues.apache.org/jira/browse/OFBIZ-1605
> Project: OFBiz
> Issue Type: Bug
> Components: content, ecommerce
> Affects Versions: SVN trunk, Release Branch 4.0
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: SurveyServices.xml.patch
>
>
> I propose this patch. You can see the thread here http://www.nabble.com/Re%3A-Gift-Card-Number-issue-td15125178.html.
> I nobody complains I will commit this patch soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.