You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/12/11 08:08:00 UTC
[GitHub] [camel-k] tadayosi opened a new issue #1859: Should 'kamel uninstall --all' also delete camel-k-registry-secret?
tadayosi opened a new issue #1859:
URL: https://github.com/apache/camel-k/issues/1859
Currently `kamel uninstall --all` doesn't delete `camel-k-registry-secret` if it was generated with `kamel install --registry ...`.
```
$ kamel uninstall --all
Camel K Integration Platform removed from namespace default
Camel K Config Maps removed from namespace default
Camel K Operator removed from namespace default
Camel K Role Bindings removed from namespace default
Camel K Roles removed from namespace default
Camel K Service Accounts removed from namespace default
Camel K Custom Resource Definitions removed from cluster
Camel K Cluster Role Bindings removed from cluster
Camel K Cluster Roles removed from cluster
$ kubectl get secrets
NAME TYPE DATA AGE
camel-k-registry-secret kubernetes.io/dockerconfigjson 1 14h
default-token-48wb7 kubernetes.io/service-account-token 3 178d
...
```
Maybe it should remove the registry and also provide an option `--skip-registry` for users who don't want it to be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] nicolaferraro commented on issue #1859: Should 'kamel uninstall --all' also delete camel-k-registry-secret?
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on issue #1859:
URL: https://github.com/apache/camel-k/issues/1859#issuecomment-743106414
Yes, sounds good, I think we add some labels to detect if it's generated by us, btw that name is usually used only by our CLI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on issue #1859: Should 'kamel uninstall --all' also delete camel-k-registry-secret?
Posted by GitBox <gi...@apache.org>.
tadayosi commented on issue #1859:
URL: https://github.com/apache/camel-k/issues/1859#issuecomment-745758707
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi closed issue #1859: Should 'kamel uninstall --all' also delete camel-k-registry-secret?
Posted by GitBox <gi...@apache.org>.
tadayosi closed issue #1859:
URL: https://github.com/apache/camel-k/issues/1859
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on issue #1859: Should 'kamel uninstall --all' also delete camel-k-registry-secret?
Posted by GitBox <gi...@apache.org>.
tadayosi commented on issue #1859:
URL: https://github.com/apache/camel-k/issues/1859#issuecomment-744281614
@nicolaferraro Thanks. So maybe should we add a label `app=camel-k` for the generated secret and clean up them if they have the label under uninstalling?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org