[GitHub] [incubator-nuttx] a-lunev commented on a change in pull request #5242: net/tcp/sendfile: TCP retransmission could not start because of incorrect snd_ackcb callback handling

[GitBox <gi...@apache.org>]

a-lunev commented on a change in pull request #5242:
URL: https://github.com/apache/incubator-nuttx/pull/5242#discussion_r785992413



##########
File path: net/tcp/tcp_sendfile.c
##########
@@ -320,41 +298,38 @@ static uint16_t sendfile_eventhandler(FAR struct net_driver_s *dev,
 
           tcp_setsequence(conn->sndseq, seqno);
 
+          /* Notify the device driver of the availability of TX data */
+
+          sendfile_txnotify(psock, conn);
+
           /* Update the amount of data sent (but not necessarily ACKed) */
 
           pstate->snd_sent += sndlen;
           ninfo("pid: %d SEND: acked=%" PRId32 " sent=%zd flen=%zu\n",
                 getpid(),
                 pstate->snd_acked, pstate->snd_sent, pstate->snd_flen);
         }
-      else
-        {
-          nwarn("WARNING: Window full, wait for ack\n");
-          goto wait;
-        }
     }
 
-  if (pstate->snd_sent >= pstate->snd_flen

Review comment:
       The check for outstanding acks is in line 186 in the changed code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org