[GitHub] [iceberg] karuppayya commented on a change in pull request #2677: Core: Support retrieving version hint location for static tables

[GitBox <gi...@apache.org>]

karuppayya commented on a change in pull request #2677:
URL: https://github.com/apache/iceberg/pull/2677#discussion_r645844405



##########
File path: core/src/main/java/org/apache/iceberg/ReachableFileUtil.java
##########
@@ -43,8 +44,10 @@ private ReachableFileUtil() {
    * @return the location of the version hint file
    */
   public static String versionHintLocation(Table table) {
-    TableOperations ops = ((HasTableOperations) table).operations();
-    return ops.metadataFileLocation(Util.VERSION_HINT_FILENAME);
+    // only Hadoop tables have a hint file and such tables have a fixed metadata layout
+    Path metadataPath = new Path(table.location(), "metadata");

Review comment:
       nit: this could be a static constant




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org