You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2009/09/15 17:34:00 UTC
[jira] Created: (SOLR-1432) FunctionQueries aren't correctly
weighted
FunctionQueries aren't correctly weighted
-----------------------------------------
Key: SOLR-1432
URL: https://issues.apache.org/jira/browse/SOLR-1432
Project: Solr
Issue Type: Bug
Affects Versions: 1.4
Reporter: Yonik Seeley
Fix For: 1.4
Nested queries in function queries aren't weighted correctly with the proper Searcher, and this is now even more serious with per-segment searching in Lucene/Solr.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1432) FunctionQueries aren't correctly
weighted
Posted by "josh lucas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777324#action_12777324 ]
josh lucas commented on SOLR-1432:
----------------------------------
I wish this issue would have been called out in the CHANGES file for the 1.4.0 release. It bit me since our ValueSource classes were not overriding this new method.
> FunctionQueries aren't correctly weighted
> -----------------------------------------
>
> Key: SOLR-1432
> URL: https://issues.apache.org/jira/browse/SOLR-1432
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-1432.patch, SOLR-1432.patch
>
>
> Nested queries in function queries aren't weighted correctly with the proper Searcher, and this is now even more serious with per-segment searching in Lucene/Solr.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1432) FunctionQueries aren't correctly
weighted
Posted by "patrick o'leary (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779219#action_12779219 ]
patrick o'leary commented on SOLR-1432:
---------------------------------------
Shouldn't ValueSource simply be updated to
{code}
public DocValues getValues(Map context, IndexReader reader) throws IOException {
return getValues(reader);
}
{code}
Rather than null, not ideal but at least it doesn't leave folks in a worse position than using 1.3-
> FunctionQueries aren't correctly weighted
> -----------------------------------------
>
> Key: SOLR-1432
> URL: https://issues.apache.org/jira/browse/SOLR-1432
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-1432.patch, SOLR-1432.patch
>
>
> Nested queries in function queries aren't weighted correctly with the proper Searcher, and this is now even more serious with per-segment searching in Lucene/Solr.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1432) FunctionQueries aren't correctly
weighted
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777674#action_12777674 ]
Hoss Man commented on SOLR-1432:
--------------------------------
bq. I wish this issue would have been called out in the CHANGES file for the 1.4.0 release
You're right ... it was a pretty big oversight on our part that it wasn't mentioned anywhere (let alone specificly called out in the "Upgrading" section.
retroactively editing CHANGES.txt isn't really feasible, but i've added it to the Solr1.4 wiki page to try and increase the visibility a bit...
http://wiki.apache.org/solr/Solr1.4
> FunctionQueries aren't correctly weighted
> -----------------------------------------
>
> Key: SOLR-1432
> URL: https://issues.apache.org/jira/browse/SOLR-1432
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-1432.patch, SOLR-1432.patch
>
>
> Nested queries in function queries aren't weighted correctly with the proper Searcher, and this is now even more serious with per-segment searching in Lucene/Solr.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SOLR-1432) FunctionQueries aren't correctly
weighted
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley reassigned SOLR-1432:
----------------------------------
Assignee: Yonik Seeley
> FunctionQueries aren't correctly weighted
> -----------------------------------------
>
> Key: SOLR-1432
> URL: https://issues.apache.org/jira/browse/SOLR-1432
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 1.4
>
>
> Nested queries in function queries aren't weighted correctly with the proper Searcher, and this is now even more serious with per-segment searching in Lucene/Solr.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1432) FunctionQueries aren't correctly
weighted
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-1432:
-------------------------------
Attachment: SOLR-1432.patch
Updated patch with tests that fail w/o correct weighting behavior.
> FunctionQueries aren't correctly weighted
> -----------------------------------------
>
> Key: SOLR-1432
> URL: https://issues.apache.org/jira/browse/SOLR-1432
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-1432.patch, SOLR-1432.patch
>
>
> Nested queries in function queries aren't weighted correctly with the proper Searcher, and this is now even more serious with per-segment searching in Lucene/Solr.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-1432) FunctionQueries aren't correctly
weighted
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley resolved SOLR-1432.
--------------------------------
Resolution: Fixed
> FunctionQueries aren't correctly weighted
> -----------------------------------------
>
> Key: SOLR-1432
> URL: https://issues.apache.org/jira/browse/SOLR-1432
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-1432.patch, SOLR-1432.patch
>
>
> Nested queries in function queries aren't weighted correctly with the proper Searcher, and this is now even more serious with per-segment searching in Lucene/Solr.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1432) FunctionQueries aren't correctly
weighted
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-1432:
-------------------------------
Attachment: SOLR-1432.patch
Here's the essence of the patch that adds a simple/flexible untyped weighting scheme to ValueSource:
{code}
/** Implementations should propagate createWeight to sub-ValueSources which can optionally store
* weight info in the context. The context object will be passed to getValues()
* where this info can be retrieved. */
public void createWeight(Map context, Searcher searcher) throws IOException {
}
{code}
> FunctionQueries aren't correctly weighted
> -----------------------------------------
>
> Key: SOLR-1432
> URL: https://issues.apache.org/jira/browse/SOLR-1432
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-1432.patch
>
>
> Nested queries in function queries aren't weighted correctly with the proper Searcher, and this is now even more serious with per-segment searching in Lucene/Solr.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1432) FunctionQueries aren't correctly
weighted
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779234#action_12779234 ]
Yonik Seeley commented on SOLR-1432:
------------------------------------
Yep, that's what it should have been. I'll change.
> FunctionQueries aren't correctly weighted
> -----------------------------------------
>
> Key: SOLR-1432
> URL: https://issues.apache.org/jira/browse/SOLR-1432
> Project: Solr
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-1432.patch, SOLR-1432.patch
>
>
> Nested queries in function queries aren't weighted correctly with the proper Searcher, and this is now even more serious with per-segment searching in Lucene/Solr.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.