You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "XN137 (via GitHub)" <gi...@apache.org> on 2025/07/23 09:01:02 UTC
[PR] Rework getOrCreateSessionSupplier [polaris]
XN137 opened a new pull request, #2161:
URL: https://github.com/apache/polaris/pull/2161
note how all the caller immediately called `get` on the returned `Supplier`. it seems like the `Supplier` was an leaking implementation detail of the `MetaStoreManagerFactor` implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rework getOrCreateSessionSupplier [polaris]
Posted by "XN137 (via GitHub)" <gi...@apache.org>.
XN137 commented on PR #2161:
URL: https://github.com/apache/polaris/pull/2161#issuecomment-3110201191
rebased after tiny conflicts with 5faa3712cb8f0ae8140d096565734432d5391eb1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rework getOrCreateSessionSupplier [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #2161:
URL: https://github.com/apache/polaris/pull/2161#issuecomment-3109809621
@XN137 : Changes LGTM. Please resolve conflicts :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rework getOrCreateSessionSupplier [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b merged PR #2161:
URL: https://github.com/apache/polaris/pull/2161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rework getOrCreateSessionSupplier [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2161:
URL: https://github.com/apache/polaris/pull/2161#discussion_r2226414635
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##########
@@ -212,7 +211,7 @@ public synchronized Supplier<BasePersistence> getOrCreateSessionSupplier(
checkPolarisServiceBootstrappedForRealm(
realmContext, metaStoreManagerMap.get(realmContext.getRealmIdentifier()));
}
- return sessionSupplierMap.get(realmContext.getRealmIdentifier());
+ return sessionSupplierMap.get(realmContext.getRealmIdentifier()).get();
Review Comment:
nit: previously the `.get()` call was outside the `synchronized` block... not sure it matters, though :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org