You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "smiklosovic (via GitHub)" <gi...@apache.org> on 2023/03/16 12:06:16 UTC
[GitHub] [cassandra] smiklosovic opened a new pull request, #2222: CASSANDRA-12937 rebased against trunk
smiklosovic opened a new pull request, #2222:
URL: https://github.com/apache/cassandra/pull/2222
Thanks for sending a pull request! Here are some tips if you're new here:
* Ensure you have added or run the [appropriate tests](https://cassandra.apache.org/_/development/testing.html) for your PR.
* Be sure to keep the PR description updated to reflect all changes.
* Write your PR title to summarize what this PR proposes.
* If possible, provide a concise example to reproduce the issue for a faster review.
* Read our [contributor guidelines](https://cassandra.apache.org/_/development/index.html)
* If you're making a documentation change, see our [guide to documentation contribution](https://cassandra.apache.org/_/development/documentation.html)
Commit messages should follow the following format:
```
<One sentence description, usually Jira title or CHANGES.txt summary>
<Optional lengthier description (context on patch)>
patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>
```
The [Cassandra Jira](https://issues.apache.org/jira/projects/CASSANDRA/issues/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159535532
##########
src/java/org/apache/cassandra/config/ConfigurationMap.java:
##########
Review Comment:
what's the purpose of this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159535145
##########
conf/cassandra.yaml:
##########
@@ -566,6 +566,14 @@ commitlog_segment_size: 32MiB
#
# flush_compression: fast
+# Defines the compression params used to read/write the sstables. If undefined the default is LZ4 with 16kb chunk
+# length and min_compress_ratio of 0.0 (see CompressionParams.DEFAULT_MIN_COMPRESS_RATIO).
+# This is the default options for sstable compression, the (schema) table-level settings will override this option.
+#sstable_compressor:
+# class: "org.apache.cassandra.io.compress.LZ4Compressor"
Review Comment:
```suggestion
# class_name: "LZ4Compressor"
```
here, and in table options, it would be nice to have some aliases to known compressors: none, lz4, snappy, deflate, zstd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159545289
##########
conf/cassandra.yaml:
##########
@@ -566,6 +566,14 @@ commitlog_segment_size: 32MiB
#
# flush_compression: fast
+# Defines the compression params used to read/write the sstables. If undefined the default is LZ4 with 16kb chunk
+# length and min_compress_ratio of 0.0 (see CompressionParams.DEFAULT_MIN_COMPRESS_RATIO).
+# This is the default options for sstable compression, the (schema) table-level settings will override this option.
+#sstable_compressor:
+# class: "org.apache.cassandra.io.compress.LZ4Compressor"
Review Comment:
what's the harm is providing aliases to the simple class names ?
I see benefit and simplicity in permitting the user to define any of the following (to the same effect)
```
class: "lz4"
class: "LZ4Compressor"
class: "org.apache.cassandra.io.compress.LZ4Compressor"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159545289
##########
conf/cassandra.yaml:
##########
@@ -566,6 +566,14 @@ commitlog_segment_size: 32MiB
#
# flush_compression: fast
+# Defines the compression params used to read/write the sstables. If undefined the default is LZ4 with 16kb chunk
+# length and min_compress_ratio of 0.0 (see CompressionParams.DEFAULT_MIN_COMPRESS_RATIO).
+# This is the default options for sstable compression, the (schema) table-level settings will override this option.
+#sstable_compressor:
+# class: "org.apache.cassandra.io.compress.LZ4Compressor"
Review Comment:
what's the harm is providing aliases to the simple class names ?
I see benefit and simplicity in permitting the user to define any of the following (to the same effect)
```
class_name: "lz4"
class_name: "LZ4Compressor"
class_name: "org.apache.cassandra.io.compress.LZ4Compressor"
```
(note, `class_name` is the standard in the yaml)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159541540
##########
conf/cassandra.yaml:
##########
@@ -566,6 +566,14 @@ commitlog_segment_size: 32MiB
#
# flush_compression: fast
+# Defines the compression params used to read/write the sstables. If undefined the default is LZ4 with 16kb chunk
+# length and min_compress_ratio of 0.0 (see CompressionParams.DEFAULT_MIN_COMPRESS_RATIO).
+# This is the default options for sstable compression, the (schema) table-level settings will override this option.
+#sstable_compressor:
+# class: "org.apache.cassandra.io.compress.LZ4Compressor"
Review Comment:
I disagree. We are using here the very same approach where we can plug-in things. It is well-known pattern that these things are referenced by FQCN (or just simple class name and package will be resolved automatically).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159560204
##########
conf/cassandra.yaml:
##########
@@ -566,6 +566,14 @@ commitlog_segment_size: 32MiB
#
# flush_compression: fast
+# Defines the compression params used to read/write the sstables. If undefined the default is LZ4 with 16kb chunk
+# length and min_compress_ratio of 0.0 (see CompressionParams.DEFAULT_MIN_COMPRESS_RATIO).
+# This is the default options for sstable compression, the (schema) table-level settings will override this option.
+#sstable_compressor:
+# class: "org.apache.cassandra.io.compress.LZ4Compressor"
+# chunk_length_in_kb: "16"
+# min_compress_ratio: "0"
Review Comment:
Yeah, so `class_name`. ParameterizedClass has it everywhere like `class_name` if I am not mistaken. Properties for compressor would be "parameters"
public class ParameterizedClass
{
public static final String CLASS_NAME = "class_name";
public static final String PARAMETERS = "parameters";
public String class_name;
public Map<String, String> parameters;
public ParameterizedClass()
{
// for snakeyaml
}
I think it is better to follow yaml naming (class_name and parameters) and then parameters would have keys and values as in CQL to have it generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159529039
##########
conf/cassandra.yaml:
##########
@@ -566,6 +566,14 @@ commitlog_segment_size: 32MiB
#
# flush_compression: fast
+# Defines the compression params used to read/write the sstables. If undefined the default is LZ4 with 16kb chunk
+# length and min_compress_ratio of 0.0 (see CompressionParams.DEFAULT_MIN_COMPRESS_RATIO).
+# This is the default options for sstable compression, the (schema) table-level settings will override this option.
Review Comment:
```suggestion
# To disable compression set `type: none` or `type: none`NoopCompressor`
# This is the default options for sstable compression, the (schema) table-level settings will override this option.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159534133
##########
conf/cassandra.yaml:
##########
@@ -566,6 +566,14 @@ commitlog_segment_size: 32MiB
#
# flush_compression: fast
+# Defines the compression params used to read/write the sstables. If undefined the default is LZ4 with 16kb chunk
+# length and min_compress_ratio of 0.0 (see CompressionParams.DEFAULT_MIN_COMPRESS_RATIO).
+# This is the default options for sstable compression, the (schema) table-level settings will override this option.
+#sstable_compressor:
+# class: "org.apache.cassandra.io.compress.LZ4Compressor"
+# chunk_length_in_kb: "16"
+# min_compress_ratio: "0"
Review Comment:
can we please take these back to `parameters` like @Claudenw originally had them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159553140
##########
conf/cassandra.yaml:
##########
@@ -566,6 +566,14 @@ commitlog_segment_size: 32MiB
#
# flush_compression: fast
+# Defines the compression params used to read/write the sstables. If undefined the default is LZ4 with 16kb chunk
+# length and min_compress_ratio of 0.0 (see CompressionParams.DEFAULT_MIN_COMPRESS_RATIO).
+# This is the default options for sstable compression, the (schema) table-level settings will override this option.
+#sstable_compressor:
+# class: "org.apache.cassandra.io.compress.LZ4Compressor"
Review Comment:
ah right ... as long as we are not introducing some "type" field or similar ... that might work. Let's explore that. But anyway, "lz4" is not a _class_ to be exact. But if it simplifies things, why not ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159544373
##########
src/java/org/apache/cassandra/config/ConfigurationMap.java:
##########
Review Comment:
Simple wrapper around hash map to have it dandy. We can replace it for `ParametrizedClass` as mentioned above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic closed pull request #2222: CASSANDRA-12937 rebased against trunk
URL: https://github.com/apache/cassandra/pull/2222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159535145
##########
conf/cassandra.yaml:
##########
@@ -566,6 +566,14 @@ commitlog_segment_size: 32MiB
#
# flush_compression: fast
+# Defines the compression params used to read/write the sstables. If undefined the default is LZ4 with 16kb chunk
+# length and min_compress_ratio of 0.0 (see CompressionParams.DEFAULT_MIN_COMPRESS_RATIO).
+# This is the default options for sstable compression, the (schema) table-level settings will override this option.
+#sstable_compressor:
+# class: "org.apache.cassandra.io.compress.LZ4Compressor"
Review Comment:
```suggestion
# class_name: "LZ4Compressor"
```
here, and in table options, it would be nice to have some aliases to known compressors: none, lz4, snappy, deflate, zstd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159529039
##########
conf/cassandra.yaml:
##########
@@ -566,6 +566,14 @@ commitlog_segment_size: 32MiB
#
# flush_compression: fast
+# Defines the compression params used to read/write the sstables. If undefined the default is LZ4 with 16kb chunk
+# length and min_compress_ratio of 0.0 (see CompressionParams.DEFAULT_MIN_COMPRESS_RATIO).
+# This is the default options for sstable compression, the (schema) table-level settings will override this option.
Review Comment:
```suggestion
# To disable compression set `type: none` or `type: none`org.apache.cassandra.io.compress..NoopCompressor`
# This is the default options for sstable compression, the (schema) table-level settings will override this option.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159543467
##########
conf/cassandra.yaml:
##########
@@ -566,6 +566,14 @@ commitlog_segment_size: 32MiB
#
# flush_compression: fast
+# Defines the compression params used to read/write the sstables. If undefined the default is LZ4 with 16kb chunk
+# length and min_compress_ratio of 0.0 (see CompressionParams.DEFAULT_MIN_COMPRESS_RATIO).
+# This is the default options for sstable compression, the (schema) table-level settings will override this option.
+#sstable_compressor:
+# class: "org.apache.cassandra.io.compress.LZ4Compressor"
+# chunk_length_in_kb: "16"
+# min_compress_ratio: "0"
Review Comment:
so you want that to be same as for e.g.seed_provider? `class_name` + parameters so it translates to `ParametrizedClass`? That might work ... we would get rid of some helper classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159535145
##########
conf/cassandra.yaml:
##########
@@ -566,6 +566,14 @@ commitlog_segment_size: 32MiB
#
# flush_compression: fast
+# Defines the compression params used to read/write the sstables. If undefined the default is LZ4 with 16kb chunk
+# length and min_compress_ratio of 0.0 (see CompressionParams.DEFAULT_MIN_COMPRESS_RATIO).
+# This is the default options for sstable compression, the (schema) table-level settings will override this option.
+#sstable_compressor:
+# class: "org.apache.cassandra.io.compress.LZ4Compressor"
Review Comment:
```suggestion
# class: "LZ4Compressor"
```
here, and in table options, it would be nice to have some aliases to known compressors: none, lz4, snappy, deflate, zstd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159553140
##########
conf/cassandra.yaml:
##########
@@ -566,6 +566,14 @@ commitlog_segment_size: 32MiB
#
# flush_compression: fast
+# Defines the compression params used to read/write the sstables. If undefined the default is LZ4 with 16kb chunk
+# length and min_compress_ratio of 0.0 (see CompressionParams.DEFAULT_MIN_COMPRESS_RATIO).
+# This is the default options for sstable compression, the (schema) table-level settings will override this option.
+#sstable_compressor:
+# class: "org.apache.cassandra.io.compress.LZ4Compressor"
Review Comment:
ah right ... as long as we are not introducing some "type" field or similar ... that might work. Let's explore that. But anyway, "lz4" is not a _class_ to be exact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159554721
##########
conf/cassandra.yaml:
##########
@@ -566,6 +566,14 @@ commitlog_segment_size: 32MiB
#
# flush_compression: fast
+# Defines the compression params used to read/write the sstables. If undefined the default is LZ4 with 16kb chunk
+# length and min_compress_ratio of 0.0 (see CompressionParams.DEFAULT_MIN_COMPRESS_RATIO).
+# This is the default options for sstable compression, the (schema) table-level settings will override this option.
+#sstable_compressor:
+# class: "org.apache.cassandra.io.compress.LZ4Compressor"
+# chunk_length_in_kb: "16"
+# min_compress_ratio: "0"
Review Comment:
`class_name` is the standard in yaml and `class` in table options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk
Posted by "michaelsembwever (via GitHub)" <gi...@apache.org>.
michaelsembwever commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159513607
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -94,6 +94,7 @@
import org.apache.cassandra.locator.InetAddressAndPort;
import org.apache.cassandra.locator.Replica;
import org.apache.cassandra.locator.SeedProvider;
+import org.apache.cassandra.schema.CompressionParams;
Review Comment:
can we please not import schema class into this package.
this was already raised and addressed here: https://github.com/apache/cassandra/pull/2199#discussion_r1139429951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org