[GitHub] [arrow-datafusion] liukun4515 commented on pull request #4255: Support parquet page filtering on min_max for `decimal128` and `string` columns

[GitBox <gi...@apache.org>]

liukun4515 commented on PR #4255:
URL: https://github.com/apache/arrow-datafusion/pull/4255#issuecomment-1319494081

   > 
   
   
   
   > Thank you @Ted-Jiang -- this looks great
   > 
   > I wonder if it would be possible to add some more targeted testing for the string and decimal page indexes in https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/tests/parquet/page_pruning.rs
   > 
   > The current test in `parquet_exec` I think ensures that the plumbing is all hooked up correctly, but I think some more targeted testing would be good too
   > 
   > However, overall I think this PR could also go in as is. Thanks a lot!
   
   agree.
   
   @Ted-Jiang 
   We can add more test for this, and use different physical data type with different decimal data type(diff precision and scale are better)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org