[jira] [Commented] (NIFI-11591) Address failing system tests

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-11591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725923#comment-17725923 ] 

ASF subversion and git services commented on NIFI-11591:
--------------------------------------------------------

Commit 108f841525f98aab8144c0421a1ea5e5cb2a3b3b in nifi's branch refs/heads/main from Mark Payne
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=108f841525 ]

NIFI-11591 Corrected intermittent system test failures

When waiting for a Processor to stop completely in system tests, also consider any terminated threads. Consider the processor stopped only when all active threads and all terminated threads have gone to 0. Additionally, when stopping all components in a Process Group, wait for the PG to reflect that there are no running components.  Previously, we checked for processor active thread counts. However, this was problematic because the flow that was fetched was not fetched recursively and as a result, processors running in embedded groups were not always stopped when the waitForProcessorsStopped(String groupId) method returned. Finally, removed the step for gathering surefire-reports in failed system tests because it was not working as expected and was unneeded because the tests' logs were already gathered into the diagnostic dump that is uploaded.

Added fix for BatchFlowBetweenGroupsIT. The test would intermittently fail, based on timing. The test assumed that when Input Port in Group B was scheduled to run, it would trigger before FlowFiles in Group A finished processing. The Sleep processor caused a 10 ms delay for each of 5 FlowFiles which gives the Input Port about 50 ms to trigger. If it took longer to trigger the first time, the test failed. Adjusted the Sleep processor to use 2 seconds. So now instead of 50 milliseconds to start, it has 10 seconds. Overall this adds about 30-45 seconds to the run time of the test but ensures more-than-adequate time for the test to run, even on extremely slow hardware

This closes #7289

Signed-off-by: David Handermann <ex...@apache.org>


> Address failing system tests
> ----------------------------
>
>                 Key: NIFI-11591
>                 URL: https://issues.apache.org/jira/browse/NIFI-11591
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework, Tools and Build
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>            Priority: Major
>             Fix For: 1.latest, 2.latest
>
>
> We've been seeing intermittent failures in the following system tests:
> - DynamicClasspathModificationIT
> - RegistryClientIT#testControllerServiceUpdateWhileRunning
> - ClusteredRegistryClientIT#testControllerServiceUpdateWhileRunning
> Additionally, NIFI-11557 introduced a surefire-report step in the system tests to attempt to capture more logs from failures, but that step is not working as expected and additionally it appears that the log output from the tests themselves is already captured into the diagnostic dump that is included.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)