[jira] Issue Comment Edited: (LUCENENET-172) This patch fixes the unexceptional exceptions ecountered in FastCharStream and SupportClass

["Ben Martz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENENET-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675629#action_12675629 ] 

benmartz edited comment on LUCENENET-172 at 2/21/09 11:25 PM:
---------------------------------------------------------------

George,

I would be grateful if you would please be very specific about exactly what this will break and in what circumstances. I understand, respect and fully appreciate your seniority and role in this project but I would really like to hear more from you about the specific issues this patch causes so that we can all learn from your experience. While I can not claim to have tested any and all possible scenarios, this code has been deployed in multiple production environments for more than a year with no demonstrable ill effects and the significant positive effect of improving indexing performance.

Thanks,
Ben

EDIT: I should further comment that as I may have alluded to but not specifically stated, I AM NOT requesting that this patch to be included in the trunk but rather that the issue needs to be documented and a fix available for anyone who explicitly makes the informed decision to deploy it. Cheers - Ben.

      was (Author: benmartz):
    George,

I would be grateful if you would please be very specific about exactly what this will break and in what circumstances. I understand, respect and fully appreciate your seniority and role in this project but I would really like to hear more from you about the specific issues this patch causes so that we can all learn from your experience. While I can not claim to have tested any and all possible scenarios, this code has been deployed in multiple production environments for more than a year with no demonstrable ill effects and the significant positive effect of improving indexing performance.

Thanks,
Ben
  
> This patch fixes the unexceptional exceptions ecountered in FastCharStream and SupportClass
> -------------------------------------------------------------------------------------------
>
>                 Key: LUCENENET-172
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-172
>             Project: Lucene.Net
>          Issue Type: Improvement
>            Reporter: Ben Martz
>         Attachments: lucene_2.3.1_exceptions_fix.patch
>
>
> The java version of Lucene handles end-of-file in FastCharStream by throwing an exception. This behavior has been ported to .NET but the behavior carries an unacceptable cost in the .NET environment. This patch is based on the prior work in LUCENENET-8 and LUCENENET-11, which I gratefully acknowledge for the solution. While I understand that this patch is outside of the current project specification in that it deviates from the "pure" nature of the port, I believe that it is very important to make the patch available to any developer looking to leverage Lucene.Net in their project. Thanks for your consideration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.