You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/09 10:43:00 UTC
[jira] [Commented] (PARQUET-1489) Insufficient documentation for
UserDefinedPredicate.keep(T)
[ https://issues.apache.org/jira/browse/PARQUET-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738093#comment-16738093 ]
ASF GitHub Bot commented on PARQUET-1489:
-----------------------------------------
gszadovszky commented on pull request #588: PARQUET-1489: Insufficient documentation for UserDefinedPredicate.keep(T)
URL: https://github.com/apache/parquet-mr/pull/588
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Insufficient documentation for UserDefinedPredicate.keep(T)
> -----------------------------------------------------------
>
> Key: PARQUET-1489
> URL: https://issues.apache.org/jira/browse/PARQUET-1489
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-mr
> Reporter: Gabor Szadovszky
> Assignee: Gabor Szadovszky
> Priority: Major
> Labels: pull-request-available
>
> The parquet-mr library invokes [UserDefinedPredicate.keep(T)|https://github.com/apache/parquet-mr/blob/master/parquet-column/src/main/java/org/apache/parquet/filter2/predicate/UserDefinedPredicate.java#L47] with {{null}} values. (This is the only way parquet-mr can check if a {{null}} fulfills the UDP.) This fact is not highlighted in the documentation of the method which can easily lead to an unexpected NPE.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)