You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/14 04:02:53 UTC

[GitHub] [shardingsphere] strongduanmu opened a new pull request, #20965: Create new shardingsphere-sql-federation-executor-core module to handle common executor logic

strongduanmu opened a new pull request, #20965:
URL: https://github.com/apache/shardingsphere/pull/20965

   Ref #20710.
   
   Changes proposed in this pull request:
     - create new shardingsphere-sql-federation-executor-core module to handle common executor logic
     - rename shardingsphere-sql-federation-original-executor to shardingsphere-sql-federation-executor-original
     - rename shardingsphere-sql-federation-advanced-executor to shardingsphere-sql-federation-executor-advanced
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [x] I have triggered maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
   - [x] I have made corresponding changes to the documentation.
   - [x] I have added corresponding unit tests for my changes.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #20965: Create new shardingsphere-sql-federation-executor-core module to handle common executor logic

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20965:
URL: https://github.com/apache/shardingsphere/pull/20965#issuecomment-1246235063

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20965?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#20965](https://codecov.io/gh/apache/shardingsphere/pull/20965?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4723994) into [master](https://codecov.io/gh/apache/shardingsphere/commit/5849b5aabbb6fed04b7a3c1d4d9d8b0bbb5a615f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5849b5a) will **increase** coverage by `0.00%`.
   > The diff coverage is `55.55%`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #20965   +/-   ##
   =========================================
     Coverage     61.80%   61.80%           
   - Complexity     2464     2465    +1     
   =========================================
     Files          4032     4034    +2     
     Lines         55441    55446    +5     
     Branches       9398     9398           
   =========================================
   + Hits          34267    34271    +4     
   - Misses        18305    18306    +1     
     Partials       2869     2869           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20965?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../data/pipeline/core/execute/PipelineJobWorker.java](https://codecov.io/gh/apache/shardingsphere/pull/20965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvZXhlY3V0ZS9QaXBlbGluZUpvYldvcmtlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ore/metadata/node/PipelineMetaDataNodeWatcher.java](https://codecov.io/gh/apache/shardingsphere/pull/20965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2NvcmUvbWV0YWRhdGEvbm9kZS9QaXBlbGluZU1ldGFEYXRhTm9kZVdhdGNoZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ederation/advanced/AdvancedFederationExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/20965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yLWFkdmFuY2VkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWxmZWRlcmF0aW9uL2FkdmFuY2VkL0FkdmFuY2VkRmVkZXJhdGlvbkV4ZWN1dG9yLmphdmE=) | `22.50% <ø> (ø)` | |
   | [...sultset/AbstractUnsupportedOperationResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/20965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yLWFkdmFuY2VkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWxmZWRlcmF0aW9uL2FkdmFuY2VkL3Jlc3VsdHNldC9BYnN0cmFjdFVuc3VwcG9ydGVkT3BlcmF0aW9uUmVzdWx0U2V0LmphdmE=) | `2.70% <ø> (ø)` | |
   | [...t/AbstractUnsupportedUpdateOperationResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/20965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yLWFkdmFuY2VkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWxmZWRlcmF0aW9uL2FkdmFuY2VkL3Jlc3VsdHNldC9BYnN0cmFjdFVuc3VwcG9ydGVkVXBkYXRlT3BlcmF0aW9uUmVzdWx0U2V0LmphdmE=) | `1.20% <ø> (ø)` | |
   | [...ration/advanced/resultset/FederationResultSet.java](https://codecov.io/gh/apache/shardingsphere/pull/20965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yLWFkdmFuY2VkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWxmZWRlcmF0aW9uL2FkdmFuY2VkL3Jlc3VsdHNldC9GZWRlcmF0aW9uUmVzdWx0U2V0LmphdmE=) | `81.81% <ø> (ø)` | |
   | [...dvanced/resultset/FederationResultSetMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/20965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yLWFkdmFuY2VkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWxmZWRlcmF0aW9uL2FkdmFuY2VkL3Jlc3VsdHNldC9GZWRlcmF0aW9uUmVzdWx0U2V0TWV0YURhdGEuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...lfederation/advanced/resultset/WrapperAdapter.java](https://codecov.io/gh/apache/shardingsphere/pull/20965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yLWFkdmFuY2VkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWxmZWRlcmF0aW9uL2FkdmFuY2VkL3Jlc3VsdHNldC9XcmFwcGVyQWRhcHRlci5qYXZh) | `20.00% <ø> (ø)` | |
   | [.../advanced/table/TranslatableTableScanExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/20965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yLWFkdmFuY2VkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWxmZWRlcmF0aW9uL2FkdmFuY2VkL3RhYmxlL1RyYW5zbGF0YWJsZVRhYmxlU2NhbkV4ZWN1dG9yLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...sphere/sqlfederation/CommonExecuteDataContext.java](https://codecov.io/gh/apache/shardingsphere/pull/20965/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yL3NoYXJkaW5nc3BoZXJlLXNxbC1mZWRlcmF0aW9uLWV4ZWN1dG9yLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbGZlZGVyYXRpb24vQ29tbW9uRXhlY3V0ZURhdGFDb250ZXh0LmphdmE=) | `0.00% <ø> (ø)` | |
   | ... and [10 more](https://codecov.io/gh/apache/shardingsphere/pull/20965/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #20965: Create new shardingsphere-sql-federation-executor-core module to handle common executor logic

Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #20965:
URL: https://github.com/apache/shardingsphere/pull/20965


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org