[GitHub] [superset] amitmiran137 commented on issue #17210: [SIP-76] Proposal for custom dashboard component support

[GitBox <gi...@apache.org>]

amitmiran137 commented on issue #17210:
URL: https://github.com/apache/superset/issues/17210#issuecomment-959765954


   > I love the idea of adding more capabilities for plugins!
   > 
   > Maybe we can add more detail on exactly what kind of props should be passed to these components. Do we pass the entire dashboard state? That would make any refactor to dashboard state a breaking change. The dashboard state and component structure is an area with a lot of unpaid technical debt that makes things excessively complex, so hardening that by making it public is somewhat concerning.
   
   I've added an example on the dashboardState param we intend to pass to the components
   all was taken from the ready to review PR for this SIP:
   https://github.com/apache/superset/pull/17208


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org