You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/04/05 17:13:17 UTC

[GitHub] [helix] qqu0127 commented on a diff in pull request #2011: Attempt to fix TestDropResourceMetricsReset

qqu0127 commented on code in PR #2011:
URL: https://github.com/apache/helix/pull/2011#discussion_r843076958


##########
helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestDropResourceMetricsReset.java:
##########
@@ -148,6 +148,10 @@ public void testDropWithNoCurrentState() throws Exception {
     // Drop the resource
     setupTool.dropResourceFromCluster(clusterName, RESOURCE_NAME);
 
+    // TEMP WORKAROUND, trigger a CurrentStateChange to remove the resource monitor
+    // https://github.com/apache/helix/issues/1980
+    participant.syncStart();

Review Comment:
   Good point, updated. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org