You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by bryanhiggins <gi...@git.apache.org> on 2014/04/07 17:11:12 UTC
[GitHub] cordova-blackberry pull request: [BlackBerry10] Improvements to de...
GitHub user bryanhiggins opened a pull request:
https://github.com/apache/cordova-blackberry/pull/154
[BlackBerry10] Improvements to device deployment
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blackberry/cordova-blackberry noPassword
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-blackberry/pull/154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #154
----
commit 2939422a7adcd37e7d82eb5bed966ed1eadf47a6
Author: Bryan Higgins <bh...@blackberry.com>
Date: 2014-04-07T14:13:13Z
CB-6409 Allow detection of devices which have not yet set password
- remove requirement for 'devicepass' arg in run
- update validation check to accept 'null' as valid response for device
commit 5a3f7695ccf80e5ceac1346a5dd84f722797db0f
Author: Bryan Higgins <bh...@blackberry.com>
Date: 2014-04-07T15:07:58Z
CB-6410 Allow deployment when debug token cannot be generated
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: [BlackBerry10] Improvements to de...
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/154#issuecomment-39743948
r+ otherwise
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: [BlackBerry10] Improvements to de...
Posted by bryanhiggins <gi...@git.apache.org>.
Github user bryanhiggins commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/154#issuecomment-39742708
@jsoref r?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: [BlackBerry10] Improvements to de...
Posted by bryanhiggins <gi...@git.apache.org>.
Github user bryanhiggins closed the pull request at:
https://github.com/apache/cordova-blackberry/pull/154
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: [BlackBerry10] Improvements to de...
Posted by bryanhiggins <gi...@git.apache.org>.
Github user bryanhiggins commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/154#discussion_r11352355
--- Diff: blackberry10/bin/templates/project/cordova/lib/target-utils.js ---
@@ -254,16 +254,15 @@ _self = {
};
bb10_utils.exec(script, args, options, function (error, stdout, stderr) {
- // error code 3 corresponds to a connected device, null or "Error: null" in stderr corresponds to connected emulator
- var isSimConnected = (type === "emulator" && (
+ // error code 3 corresponds to connected device with password
+ // null or "Error: null" in stderr corresponds to connected simulator or device without password
+ var connected =
error === null ||
+ (error && error.code === 3) ||
--- End diff --
In this case 'null' has a distinct value over 'undefined'. I'll update the comment to make that clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-blackberry pull request: [BlackBerry10] Improvements to de...
Posted by jsoref <gi...@git.apache.org>.
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-blackberry/pull/154#discussion_r11348541
--- Diff: blackberry10/bin/templates/project/cordova/lib/target-utils.js ---
@@ -254,16 +254,15 @@ _self = {
};
bb10_utils.exec(script, args, options, function (error, stdout, stderr) {
- // error code 3 corresponds to a connected device, null or "Error: null" in stderr corresponds to connected emulator
- var isSimConnected = (type === "emulator" && (
+ // error code 3 corresponds to connected device with password
+ // null or "Error: null" in stderr corresponds to connected simulator or device without password
+ var connected =
error === null ||
+ (error && error.code === 3) ||
--- End diff --
You shouldn't need error &&, because the error === null || should short circuit it, unless you're expecting someone to pass `error===0` or `error===''` in which case, i think we have bigger issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---