You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/07/14 14:45:16 UTC

[GitHub] [incubator-brpc] heyuyi0906 commented on a change in pull request #1161: fix h2_req check failed when retry after ELIMIT error

heyuyi0906 commented on a change in pull request #1161:
URL: https://github.com/apache/incubator-brpc/pull/1161#discussion_r454411025



##########
File path: src/brpc/channel.cpp
##########
@@ -464,6 +464,8 @@ void Channel::CallMethod(const google::protobuf::MethodDescriptor* method,
     // Share the lb with controller.
     cntl->_lb = _lb;
 
+    // serialize_request must be done before pack_request
+    _serialize_request(&cntl->_request_buf, cntl, request);

Review comment:
       已经改进了下




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org