[GitHub] [incubator-echarts] pissang commented on pull request #12838: Add silent param to setOption

[GitBox <gi...@apache.org>]

pissang commented on pull request #12838:
URL: https://github.com/apache/incubator-echarts/pull/12838#issuecomment-647263844


   I think it's better to keep the `silent` parameter in the object. Too many parameters is not a good pattern.
   
   ```js 
   chart.setOption(option, { silent: true });
   ```
   
   The exists boolean parameter `notMerge`, `lazyUpdate`  is kept mostly for backward compatibility.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org