[GitHub] [superset] hughhhh commented on a diff in pull request #24665: fix: Dashboard time grain in Pivot Table

["hughhhh (via GitHub)" <gi...@apache.org>]

hughhhh commented on code in PR #24665:
URL: https://github.com/apache/superset/pull/24665#discussion_r1260004141


##########
superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/buildQuery.ts:
##########
@@ -30,7 +30,10 @@ import {
 import { PivotTableQueryFormData } from '../types';
 
 export default function buildQuery(formData: PivotTableQueryFormData) {
-  const { groupbyColumns = [], groupbyRows = [] } = formData;
+  const { groupbyColumns = [], groupbyRows = [], extra_form_data } = formData;

Review Comment:
   can we write a small unit test to for buildQuery to verify the grains are being properly set?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org