You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "CAICAIIs (via GitHub)" <gi...@apache.org> on 2026/08/08 18:20:55 UTC
[PR] feat(triple): share HTTP/3 QUIC config with client [dubbo-go]
CAICAIIs opened a new pull request, #3620:
URL: https://github.com/apache/dubbo-go/pull/3620
### What changed
This PR continues the HTTP/3 configuration work from #3299 and wires the direct HTTP/3 client path to the same `Http3Config -> quic.Config` mapping used by the Triple server.
Changes:
- Move the QUIC config mapper into `protocol/triple/internal/http3config`
- Reuse the shared mapper from both Triple server startup paths and the direct HTTP/3 client transport
- Preserve the existing direct HTTP/3 keepalive fallback by passing legacy keepalive values as QUIC defaults
- Let explicit `Http3Config` values override those defaults
- Add focused tests for default preservation, explicit overrides, invalid duration propagation, and server error handling
### Scope
This PR intentionally keeps the scope narrow:
- Direct HTTP/3 client path is covered
- Server path remains covered through the shared mapper
- Dual transport HTTP/3 config wiring is left for a follow-up PR
- Full code-level option APIs such as `Http3KeepAlivePeriod` / `Http3MaxIdleTimeout` are left for a separate follow-up PR
Refs #3102.
### Validation
```bash
go test ./protocol/triple/internal/http3config -count=1
go test ./protocol/triple/triple_protocol -run TestServer_HTTP3PathsUseQUICConfigHelper -count=1
go test ./protocol/triple -run 'TestNewHTTP3TransportQUICConfig|TestNewHTTP3TransportReturnsQUICConfigError' -count=1
git diff --check upstream/develop...HEAD
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(triple): share HTTP/3 QUIC config with client [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3620:
URL: https://github.com/apache/dubbo-go/pull/3620#issuecomment-5281421216
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3620) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3620&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3620&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3620&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3620&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3620&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3620)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(triple): share HTTP/3 QUIC config with client [dubbo-go]
Posted by "CAICAIIs (via GitHub)" <gi...@apache.org>.
CAICAIIs commented on PR #3620:
URL: https://github.com/apache/dubbo-go/pull/3620#issuecomment-5229763397
same: https://github.com/apache/dubbo-go-samples/issues/1129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(triple): share HTTP/3 QUIC config with client [dubbo-go]
Posted by "CAICAIIs (via GitHub)" <gi...@apache.org>.
CAICAIIs commented on code in PR #3620:
URL: https://github.com/apache/dubbo-go/pull/3620#discussion_r3759943538
##########
protocol/triple/client.go:
##########
@@ -284,6 +284,26 @@ func newClientManager(url *common.URL) (*clientManager, error) {
}, nil
}
+func newHTTP3Transport(
+ tlsConfig *tls.Config,
+ http3Config *global.Http3Config,
+ keepAliveInterval time.Duration,
+ keepAliveTimeout time.Duration,
+) (http.RoundTripper, error) {
+ quicConfig, err := http3config.NewQUICConfigWithDefaults(http3Config, &quic.Config{
+ KeepAlivePeriod: keepAliveInterval,
+ MaxIdleTimeout: keepAliveTimeout,
+ })
+ if err != nil {
+ return nil, err
+ }
+
+ return &http3.Transport{
+ TLSClientConfig: tlsConfig,
+ QUICConfig: quicConfig,
+ }, nil
+}
Review Comment:
调整了已去掉不太必要的封装
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(triple): share HTTP/3 QUIC config with client [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3620:
URL: https://github.com/apache/dubbo-go/pull/3620#issuecomment-5256005954
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3620) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3620&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3620&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3620&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3620&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3620&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3620)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(triple): share HTTP/3 QUIC config with client [dubbo-go]
Posted by "CAICAIIs (via GitHub)" <gi...@apache.org>.
CAICAIIs commented on code in PR #3620:
URL: https://github.com/apache/dubbo-go/pull/3620#discussion_r3776707772
##########
protocol/triple/client.go:
##########
@@ -227,18 +228,22 @@ func newClientManager(url *common.URL) (*clientManager, error) {
return nil, fmt.Errorf("TRIPLE http3 client must have TLS config, but TLS config is nil")
}
- // HTTP/3 transport maps keepalive to quic-go's KeepAlivePeriod and MaxIdleTimeout;
- // All other QUIC knobs keep the quic.Config defaults.
+ var http3Config *global.Http3Config
+ if tripleConf != nil {
+ http3Config = tripleConf.Http3
+ }
+ quicConfig, configErr := http3config.NewQUICConfig(http3Config, &quic.Config{
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(triple): share HTTP/3 QUIC config with client [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3620:
URL: https://github.com/apache/dubbo-go/pull/3620#issuecomment-5256829053
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3620) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3620&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3620&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3620&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3620&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3620&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3620)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(triple): share HTTP/3 QUIC config with client [dubbo-go]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3620:
URL: https://github.com/apache/dubbo-go/pull/3620#issuecomment-5227502905
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/3620?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `76.00000%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.88%. Comparing base ([`60d1c2a`](https://app.codecov.io/gh/apache/dubbo-go/commit/60d1c2a949f0ee0da4be3fe09fb79d295491e040?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5aa38c9`](https://app.codecov.io/gh/apache/dubbo-go/commit/5aa38c969313367cd37b66700d220c2eb4180d4e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 897 commits behind head on develop.
| [Files with missing lines](https://app.codecov.io/gh/apache/dubbo-go/pull/3620?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [protocol/triple/client.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3620?src=pr&el=tree&filepath=protocol%2Ftriple%2Fclient.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJvdG9jb2wvdHJpcGxlL2NsaWVudC5nbw==) | 64.70% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3620?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #3620 +/- ##
===========================================
+ Coverage 46.76% 53.88% +7.11%
===========================================
Files 295 474 +179
Lines 17172 36404 +19232
===========================================
+ Hits 8031 19615 +11584
- Misses 8287 15212 +6925
- Partials 854 1577 +723
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/dubbo-go/pull/3620?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(triple): share HTTP/3 QUIC config with client [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #3620:
URL: https://github.com/apache/dubbo-go/pull/3620#discussion_r3764623074
##########
protocol/triple/client.go:
##########
@@ -227,18 +228,22 @@ func newClientManager(url *common.URL) (*clientManager, error) {
return nil, fmt.Errorf("TRIPLE http3 client must have TLS config, but TLS config is nil")
}
- // HTTP/3 transport maps keepalive to quic-go's KeepAlivePeriod and MaxIdleTimeout;
- // All other QUIC knobs keep the quic.Config defaults.
+ var http3Config *global.Http3Config
+ if tripleConf != nil {
+ http3Config = tripleConf.Http3
+ }
+ quicConfig, configErr := http3config.NewQUICConfig(http3Config, &quic.Config{
Review Comment:
[P1] 这里的 `Http3Config` 映射仍没有接入用户实际启用 HTTP/3 的客户端路径。当前 `Http3.Enable=true` 会把 `callProtocol` 设为 `CallHTTP2AndHTTP3`，随后走 `newDualTransport`；这个 `CallHTTP3` 分支没有现有公开配置入口。public-entrypoint 探针把 `KeepAlivePeriod` 设为无效值后，`GetProtocol().Refer` 仍成功创建 dual transport，说明配置被静默忽略。请把 `Http3Config` 传入 `newDualTransport` 并用共享 mapper 构造其中的 `http3.Transport.QUICConfig`，再从公开入口覆盖显式字段和无效 duration。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(triple): share HTTP/3 QUIC config with client [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks merged PR #3620:
URL: https://github.com/apache/dubbo-go/pull/3620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(triple): share HTTP/3 QUIC config with client [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl commented on code in PR #3620:
URL: https://github.com/apache/dubbo-go/pull/3620#discussion_r3747808800
##########
protocol/triple/client.go:
##########
@@ -284,6 +284,26 @@ func newClientManager(url *common.URL) (*clientManager, error) {
}, nil
}
+func newHTTP3Transport(
+ tlsConfig *tls.Config,
+ http3Config *global.Http3Config,
+ keepAliveInterval time.Duration,
+ keepAliveTimeout time.Duration,
+) (http.RoundTripper, error) {
+ quicConfig, err := http3config.NewQUICConfigWithDefaults(http3Config, &quic.Config{
+ KeepAlivePeriod: keepAliveInterval,
+ MaxIdleTimeout: keepAliveTimeout,
+ })
+ if err != nil {
+ return nil, err
+ }
+
+ return &http3.Transport{
+ TLSClientConfig: tlsConfig,
+ QUICConfig: quicConfig,
+ }, nil
+}
Review Comment:
这个函数也没有封装一下的必要吧
##########
protocol/triple/internal/http3config/http3_config.go:
##########
@@ -30,8 +30,18 @@ import (
"dubbo.apache.org/dubbo-go/v3/global"
)
-func newQUICConfig(http3Config *global.Http3Config) (*quic.Config, error) {
+// NewQUICConfig maps HTTP/3 transport configuration to quic-go configuration.
+func NewQUICConfig(http3Config *global.Http3Config) (*quic.Config, error) {
+ return NewQUICConfigWithDefaults(http3Config, nil)
+}
Review Comment:
这个函数为啥要包一层
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(triple): share HTTP/3 QUIC config with client [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3620:
URL: https://github.com/apache/dubbo-go/pull/3620#issuecomment-5227481333
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3620) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3620&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3620&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3620&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3620&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3620&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3620)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(triple): share HTTP/3 QUIC config with client [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3620:
URL: https://github.com/apache/dubbo-go/pull/3620#issuecomment-5280739702
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3620) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3620&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3620&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3620&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3620&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3620&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3620)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org