You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/30 18:45:21 UTC
[GitHub] [iceberg] rdblue opened a new pull request, #4907: Core: Implement namespace listing with a parent in REST catalog
rdblue opened a new pull request, #4907:
URL: https://github.com/apache/iceberg/pull/4907
This implements support for passing a parent namespace to list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4907: Core: Implement namespace listing with a parent in REST catalog
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #4907:
URL: https://github.com/apache/iceberg/pull/4907#issuecomment-1141503510
Thanks for the reviews, everyone!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #4907: Core: Implement namespace listing with a parent in REST catalog
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #4907:
URL: https://github.com/apache/iceberg/pull/4907#discussion_r885033238
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -87,9 +87,9 @@ public void createCatalog() {
RESTCatalogAdapter adaptor = new RESTCatalogAdapter(backendCatalog) {
@Override
- public <T extends RESTResponse> T execute(RESTCatalogAdapter.HTTPMethod method, String path, Object body,
- Class<T> responseType, Map<String, String> headers,
- Consumer<ErrorResponse> errorHandler) {
+ public <T extends RESTResponse> T execute(RESTCatalogAdapter.HTTPMethod method, String path,
+ Map<String, String> queryParams, Object body, Class<T> responseType,
+ Map<String, String> headers, Consumer<ErrorResponse> errorHandler) {
Review Comment:
The changes to `TestRESTCatalog` are large because several lines went over the limit and had to be split out. The assertions just add `any()` to validations for query params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4907: Core: Implement namespace listing with a parent in REST catalog
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #4907:
URL: https://github.com/apache/iceberg/pull/4907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org