You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2017/11/21 23:20:31 UTC
Review Request 64006: Moved registry operations into separate header.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64006/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
The definition of the various master registry operations is only
needed when trying to access registry, so they were moved into a
separate file in order to decrease size and complexity of the
master.hpp header.
Diffs
-----
src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3
src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f
src/master/registry_operations.hpp PRE-CREATION
src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b
src/tests/partition_tests.cpp e49c474167076b4136a161ed29b11db9a13455a7
src/tests/persistent_volume_tests.cpp acfeac16884b00581a3523607ff26f44f6dca53a
src/tests/reconciliation_tests.cpp 8c43ffd1cd4ffe1b11d67eb0a1f768c736826d91
src/tests/registrar_tests.cpp b0fc5f64dbaf841a548b1e19c90ed47bd1248872
src/tests/slave_tests.cpp a75bb260df223b5b86f31e91eec1b6ba8db00cb2
Diff: https://reviews.apache.org/r/64006/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 64006: Moved registry operations into separate
header.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64006/#review191672
-----------------------------------------------------------
src/master/registry_operations.hpp
Lines 21 (patched)
<https://reviews.apache.org/r/64006/#comment269518>
Remove the FIXME.
src/master/registry_operations.hpp
Lines 33 (patched)
<https://reviews.apache.org/r/64006/#comment269515>
Let's move the implementation into a .cpp file.
src/master/registry_operations.hpp
Lines 339 (patched)
<https://reviews.apache.org/r/64006/#comment269519>
Add appropriate comment for the include guard.
- Benno Evers
On Nov. 21, 2017, 11:20 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64006/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2017, 11:20 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The definition of the various master registry operations is only
> needed when trying to access registry, so they were moved into a
> separate file in order to decrease size and complexity of the
> master.hpp header.
>
>
> Diffs
> -----
>
> src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3
> src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f
> src/master/registry_operations.hpp PRE-CREATION
> src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b
> src/tests/partition_tests.cpp e49c474167076b4136a161ed29b11db9a13455a7
> src/tests/persistent_volume_tests.cpp acfeac16884b00581a3523607ff26f44f6dca53a
> src/tests/reconciliation_tests.cpp 8c43ffd1cd4ffe1b11d67eb0a1f768c736826d91
> src/tests/registrar_tests.cpp b0fc5f64dbaf841a548b1e19c90ed47bd1248872
> src/tests/slave_tests.cpp a75bb260df223b5b86f31e91eec1b6ba8db00cb2
>
>
> Diff: https://reviews.apache.org/r/64006/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 64006: Moved registry operations into separate
header.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64006/#review192143
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Nov. 29, 2017, 6:04 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64006/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 6:04 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The definition of the various master registry operations is only
> needed when trying to access registry, so they were moved into a
> separate file in order to decrease size and complexity of the
> master.hpp header.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt be212d9316e1b8a605b2f7f2cdaae37a3b0871bf
> src/Makefile.am 9641ad4cf2a1f7fe56a4dcccb6eeff7130872fa8
> src/master/http.cpp 10084125deb839a9846a4f64d2e433ff02754c02
> src/master/master.hpp 2a2e830354db4a2191fb8321beb8174b80f7ba7d
> src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144
> src/master/registry_operations.hpp PRE-CREATION
> src/master/registry_operations.cpp PRE-CREATION
> src/tests/master_tests.cpp 01f45a9bb6378c5fded31bf58fbcad93fe7ed719
> src/tests/partition_tests.cpp e49c474167076b4136a161ed29b11db9a13455a7
> src/tests/persistent_volume_tests.cpp 56b55210ce75907bad9ca50246991c14990e0dca
> src/tests/reconciliation_tests.cpp 18551ba9955cdd3e94327710813b91cf49c97fa0
> src/tests/registrar_tests.cpp b0fc5f64dbaf841a548b1e19c90ed47bd1248872
> src/tests/slave_tests.cpp aeaa923f36af134b61ad9df93c95651a8d9bc23c
>
>
> Diff: https://reviews.apache.org/r/64006/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 64006: Moved registry operations into separate
header.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64006/
-----------------------------------------------------------
(Updated Nov. 29, 2017, 6:04 p.m.)
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
The definition of the various master registry operations is only
needed when trying to access registry, so they were moved into a
separate file in order to decrease size and complexity of the
master.hpp header.
Diffs (updated)
-----
src/CMakeLists.txt be212d9316e1b8a605b2f7f2cdaae37a3b0871bf
src/Makefile.am 9641ad4cf2a1f7fe56a4dcccb6eeff7130872fa8
src/master/http.cpp 10084125deb839a9846a4f64d2e433ff02754c02
src/master/master.hpp 2a2e830354db4a2191fb8321beb8174b80f7ba7d
src/master/master.cpp 700e12433b0b66efc3f5dd296711c0f203a13144
src/master/registry_operations.hpp PRE-CREATION
src/master/registry_operations.cpp PRE-CREATION
src/tests/master_tests.cpp 01f45a9bb6378c5fded31bf58fbcad93fe7ed719
src/tests/partition_tests.cpp e49c474167076b4136a161ed29b11db9a13455a7
src/tests/persistent_volume_tests.cpp 56b55210ce75907bad9ca50246991c14990e0dca
src/tests/reconciliation_tests.cpp 18551ba9955cdd3e94327710813b91cf49c97fa0
src/tests/registrar_tests.cpp b0fc5f64dbaf841a548b1e19c90ed47bd1248872
src/tests/slave_tests.cpp aeaa923f36af134b61ad9df93c95651a8d9bc23c
Diff: https://reviews.apache.org/r/64006/diff/5/
Changes: https://reviews.apache.org/r/64006/diff/4-5/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 64006: Moved registry operations into separate
header.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64006/#review191951
-----------------------------------------------------------
Fix it, then Ship it!
src/master/registry_operations.hpp
Lines 28 (patched)
<https://reviews.apache.org/r/64006/#comment269900>
one line only.
src/master/registry_operations.hpp
Lines 124 (patched)
<https://reviews.apache.org/r/64006/#comment269901>
one line only.
src/master/registry_operations.cpp
Lines 239 (patched)
<https://reviews.apache.org/r/64006/#comment269902>
2 lines.
- Vinod Kone
On Nov. 27, 2017, 11:29 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64006/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2017, 11:29 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The definition of the various master registry operations is only
> needed when trying to access registry, so they were moved into a
> separate file in order to decrease size and complexity of the
> master.hpp header.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 4f114184df067f4438c852cff4a40fa01861316a
> src/Makefile.am 49dec55ced32945ad0414c32eb4e00247f4b54f2
> src/master/http.cpp 10084125deb839a9846a4f64d2e433ff02754c02
> src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3
> src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f
> src/master/registry_operations.hpp PRE-CREATION
> src/master/registry_operations.cpp PRE-CREATION
> src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b
> src/tests/partition_tests.cpp e49c474167076b4136a161ed29b11db9a13455a7
> src/tests/persistent_volume_tests.cpp acfeac16884b00581a3523607ff26f44f6dca53a
> src/tests/reconciliation_tests.cpp 8c43ffd1cd4ffe1b11d67eb0a1f768c736826d91
> src/tests/registrar_tests.cpp b0fc5f64dbaf841a548b1e19c90ed47bd1248872
> src/tests/slave_tests.cpp a75bb260df223b5b86f31e91eec1b6ba8db00cb2
>
>
> Diff: https://reviews.apache.org/r/64006/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 64006: Moved registry operations into separate
header.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64006/
-----------------------------------------------------------
(Updated Nov. 27, 2017, 11:29 p.m.)
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
The definition of the various master registry operations is only
needed when trying to access registry, so they were moved into a
separate file in order to decrease size and complexity of the
master.hpp header.
Diffs (updated)
-----
src/CMakeLists.txt 4f114184df067f4438c852cff4a40fa01861316a
src/Makefile.am 49dec55ced32945ad0414c32eb4e00247f4b54f2
src/master/http.cpp 10084125deb839a9846a4f64d2e433ff02754c02
src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3
src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f
src/master/registry_operations.hpp PRE-CREATION
src/master/registry_operations.cpp PRE-CREATION
src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b
src/tests/partition_tests.cpp e49c474167076b4136a161ed29b11db9a13455a7
src/tests/persistent_volume_tests.cpp acfeac16884b00581a3523607ff26f44f6dca53a
src/tests/reconciliation_tests.cpp 8c43ffd1cd4ffe1b11d67eb0a1f768c736826d91
src/tests/registrar_tests.cpp b0fc5f64dbaf841a548b1e19c90ed47bd1248872
src/tests/slave_tests.cpp a75bb260df223b5b86f31e91eec1b6ba8db00cb2
Diff: https://reviews.apache.org/r/64006/diff/4/
Changes: https://reviews.apache.org/r/64006/diff/3-4/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 64006: Moved registry operations into separate
header.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64006/
-----------------------------------------------------------
(Updated Nov. 22, 2017, 2:04 a.m.)
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
The definition of the various master registry operations is only
needed when trying to access registry, so they were moved into a
separate file in order to decrease size and complexity of the
master.hpp header.
Diffs (updated)
-----
src/CMakeLists.txt 4f114184df067f4438c852cff4a40fa01861316a
src/Makefile.am 49dec55ced32945ad0414c32eb4e00247f4b54f2
src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3
src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f
src/master/registry_operations.hpp PRE-CREATION
src/master/registry_operations.cpp PRE-CREATION
src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b
src/tests/partition_tests.cpp e49c474167076b4136a161ed29b11db9a13455a7
src/tests/persistent_volume_tests.cpp acfeac16884b00581a3523607ff26f44f6dca53a
src/tests/reconciliation_tests.cpp 8c43ffd1cd4ffe1b11d67eb0a1f768c736826d91
src/tests/registrar_tests.cpp b0fc5f64dbaf841a548b1e19c90ed47bd1248872
src/tests/slave_tests.cpp a75bb260df223b5b86f31e91eec1b6ba8db00cb2
Diff: https://reviews.apache.org/r/64006/diff/2/
Changes: https://reviews.apache.org/r/64006/diff/1-2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 64006: Moved registry operations into separate
header.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64006/#review191675
-----------------------------------------------------------
- Confirm if internal headers need to be added to Makefile.am/CMakeLists
- Benno Evers
On Nov. 21, 2017, 11:20 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64006/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2017, 11:20 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The definition of the various master registry operations is only
> needed when trying to access registry, so they were moved into a
> separate file in order to decrease size and complexity of the
> master.hpp header.
>
>
> Diffs
> -----
>
> src/master/master.hpp a309fc78ee2613762f3d5d22ac7559afc7aac4a3
> src/master/master.cpp 2ddd67ada3731803b00883b6a1f32b20c1bb238f
> src/master/registry_operations.hpp PRE-CREATION
> src/tests/master_tests.cpp 9c450b9f592d9e09a468f537d9b500e97acc636b
> src/tests/partition_tests.cpp e49c474167076b4136a161ed29b11db9a13455a7
> src/tests/persistent_volume_tests.cpp acfeac16884b00581a3523607ff26f44f6dca53a
> src/tests/reconciliation_tests.cpp 8c43ffd1cd4ffe1b11d67eb0a1f768c736826d91
> src/tests/registrar_tests.cpp b0fc5f64dbaf841a548b1e19c90ed47bd1248872
> src/tests/slave_tests.cpp a75bb260df223b5b86f31e91eec1b6ba8db00cb2
>
>
> Diff: https://reviews.apache.org/r/64006/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>