[GitHub] [pinot] snleee commented on a diff in pull request #10758: Add a new controller endpoint for segment deletion with a time window

["snleee (via GitHub)" <gi...@apache.org>]

snleee commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1248355285


##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -884,6 +865,52 @@ public SuccessResponse deleteSegments(
     }
   }
 
+  @DELETE
+  @Consumes(MediaType.APPLICATION_JSON)
+  @Produces(MediaType.APPLICATION_JSON)
+  @Path("/segments/{tableName}/select")

Review Comment:
   @wirybeaver We deprecated `GET /segments/{tableName}/select` over `GET /segments`. (We added the annotation). 
   
   Can we add these filters to `DELETE /segments` API?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org