You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/28 15:58:01 UTC

[GitHub] [pulsar] shibd commented on a diff in pull request #16228: [improve][java client] No need print exception stack when DLQ send failed.

shibd commented on code in PR #16228:
URL: https://github.com/apache/pulsar/pull/16228#discussion_r908657187


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -2001,15 +2001,15 @@ private CompletableFuture<Boolean> processPossibleToDLQ(MessageIdImpl messageId)
                                 acknowledgeAsync(finalMessageId).whenComplete((v, ex) -> {
                                     if (ex != null) {
                                         log.warn("[{}] [{}] [{}] Failed to acknowledge the message {} of the original"
-                                                        + " topic but send to the DLQ successfully.",
-                                                topicName, subscription, consumerName, finalMessageId, ex);
+                                                        + " topic but send to the DLQ successfully {}.",
+                                                topicName, subscription, consumerName, finalMessageId, ex.getMessage());

Review Comment:
   Thanks for the careful review, Fixed. Please review again, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org