[GitHub] [flink-kubernetes-operator] tweise commented on a diff in pull request #385: [FLINK-29109] Avoid checkpoint path conflicts (Flink < 1.16)

[GitBox <gi...@apache.org>]

tweise commented on code in PR #385:
URL: https://github.com/apache/flink-kubernetes-operator/pull/385#discussion_r979497847


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/status/FlinkDeploymentStatus.java:
##########
@@ -53,4 +53,7 @@ public class FlinkDeploymentStatus extends CommonStatus<FlinkDeploymentSpec> {
 
     /** Information about the TaskManagers for the scale subresource. */
     private TaskManagerInfo taskManager;
+
+    /** The jobId, if it was set by the operator. */
+    private String overrideJobId;

Review Comment:
   Reusing jobStatus.jobId is not perfect as we are using the same field for two different purposes. But it works pretty well and is better than adding another field to status for something that is going to be phased out when >=1.16 becomes the minimum version. PTAL



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org