[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3005: ARTEMIS-2636: Introduce Disk Usage Metrics

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #3005: ARTEMIS-2636: Introduce Disk Usage Metrics
URL: https://github.com/apache/activemq-artemis/pull/3005#discussion_r391205527
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
 ##########
 @@ -2996,6 +2996,7 @@ private void registerMeters() {
             builder.register(BrokerMetricNames.CONNECTION_COUNT, this, metrics -> Double.valueOf(getConnectionCount()), ActiveMQServerControl.CONNECTION_COUNT_DESCRIPTION);
             builder.register(BrokerMetricNames.TOTAL_CONNECTION_COUNT, this, metrics -> Double.valueOf(getTotalConnectionCount()), ActiveMQServerControl.TOTAL_CONNECTION_COUNT_DESCRIPTION);
             builder.register(BrokerMetricNames.ADDRESS_MEMORY_USAGE, this, metrics -> Double.valueOf(getPagingManager().getGlobalSize()), ActiveMQServerControl.ADDRESS_MEMORY_USAGE_DESCRIPTION);
+            builder.register(BrokerMetricNames.DISK_STORE_USAGE, this, metrics -> Double.valueOf(getPagingManager().getDiskTotalSpace() - getPagingManager().getDiskUsableSpace()), ActiveMQServerControl.DISK_STORE_USAGE_DESCRIPTION);
 
 Review comment:
   Typically the words used for disk reporting are used and free to avoid any confusion.
   
   Youre using the word usage which to me suggest its the used space not the freem
   
   I would recommend we use clearer words like used and free

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services