You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/23 20:31:37 UTC
[GitHub] [pulsar] michaeljmarshall opened a new pull request #14827: Stop building Pulsar Client for Python 2.7
michaeljmarshall opened a new pull request #14827:
URL: https://github.com/apache/pulsar/pull/14827
### Motivation
We currently have several dependencies on Python 2.7. There is no need to build anything new for Python 2.7, as it has been deprecated for a while.
### Modifications
* Remove the defunct homebrew script (the real one lives upstream).
* Update comments to indicate supported python languages.
* Update the python client build so that it only releases clients for python 3.x.
### Verifying this change
I have manually run the scripts for these components to verify that the tests pass.
### Does this pull request potentially affect one of the following parts:
Yes, this is a breaking change for the python 2.7 client. Given that python 2.7 is no longer supported, this is an acceptable breaking change.
### Documentation
- [x] `doc`
There are some minor doc updates as a part of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #14827: Stop building Pulsar Client for Python 2.7
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on pull request #14827:
URL: https://github.com/apache/pulsar/pull/14827#issuecomment-1077500100
I've tried to enable Python3 for CI some months ago, see https://github.com/apache/pulsar/pull/9684 and https://github.com/apache/pulsar/pull/8624. It's harder than I've thought.
It's right that the `apachepulsar/pulsar-build:ubuntu-16.04-pb3` image doesn't have the Python3 support. We need to update the Dockerfile and add Boost Python3 dependency. But the most hard thing is the Python Functions incompatibility. It looks like Python Functions relies heavy on Python2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #14827: Stop building Pulsar Client for Python 2.7
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #14827:
URL: https://github.com/apache/pulsar/pull/14827#discussion_r833697668
##########
File path: .github/workflows/ci-cpp.yaml
##########
@@ -87,7 +87,7 @@ jobs:
if: ${{ steps.check_changes.outputs.docs_only != 'true' }}
run: |
echo "Build C++ client library"
- export CMAKE_ARGS="-DCMAKE_BUILD_TYPE=Debug -DBUILD_DYNAMIC_LIB=OFF -DPYTHON_INCLUDE_DIR=/usr/include/python2.7 -DPYTHON_LIBRARY=/usr/lib/x86_64-linux-gnu/libpython2.7.so"
+ export CMAKE_ARGS="-DCMAKE_BUILD_TYPE=Debug -DBUILD_DYNAMIC_LIB=OFF -DPYTHON_INCLUDE_DIR=/usr/include/python3.5m -DPYTHON_LIBRARY=/usr/lib/x86_64-linux-gnu/libpython3.5m.so"
Review comment:
I am having trouble with this test. I get the following error when running in a docker container on my laptop:
```
root@a89a873f16b0:/pulsar/pulsar-client-cpp# cd /pulsar/pulsar-client-cpp && cmake . $CMAKE_ARGS && make check-format && make -j8
-- ARCHITECTURE: x86_64
-- BUILD_DYNAMIC_LIB: OFF
-- BUILD_STATIC_LIB: ON
-- BUILD_TESTS: ON
-- BUILD_PYTHON_WRAPPER: ON
-- BUILD_WIRESHARK: OFF
-- BUILD_PERF_TOOLS: OFF
-- LINK_STATIC: OFF
-- USE_LOG4CXX: OFF
-- CMAKE_BUILD_TYPE: Debug
-- Threads library: -pthread
Failed to find Protobuf in config mode, try to find it from system path
-- Protobuf_LIBRARIES: /usr/local/lib/libprotobuf.so
-- Protobuf_INCLUDE_DIRS: /usr/local/include
-- Found Boost: /usr/include (found version "1.58.0")
-- Linking with Boost:System
-- Using std::regex
-- Found Boost: /usr/include (found version "1.58.0") found components: system
-- PYTHON: 3.5.2
-- DETECTED Python 3
CMake Warning at /cmake-3.22.0-linux-x86_64/share/cmake-3.22/Modules/FindBoost.cmake:2201 (message):
No header defined for python3-mt; skipping header check (note: header-only
libraries have no designated component)
Call Stack (most recent call first):
CMakeLists.txt:280 (find_package)
CMake Warning at /cmake-3.22.0-linux-x86_64/share/cmake-3.22/Modules/FindBoost.cmake:2201 (message):
No header defined for python-py35; skipping header check (note: header-only
libraries have no designated component)
Call Stack (most recent call first):
CMakeLists.txt:280 (find_package)
CMake Warning at /cmake-3.22.0-linux-x86_64/share/cmake-3.22/Modules/FindBoost.cmake:2201 (message):
No header defined for python-py35; skipping header check (note: header-only
libraries have no designated component)
Call Stack (most recent call first):
CMakeLists.txt:291 (find_package)
-- Found Boost: /usr/include (found version "1.58.0") found components: python-py35
-- HAS_ZSTD: 1
-- HAS_SNAPPY: 1
-- Using Boost Python libs:
CMake Error at python/CMakeLists.txt:84 (MESSAGE):
Could not find Boost Python library
-- Configuring incomplete, errors occurred!
See also "/pulsar/pulsar-client-cpp/CMakeFiles/CMakeOutput.log".
See also "/pulsar/pulsar-client-cpp/CMakeFiles/CMakeError.log".
```
It is likely that `apachepulsar/pulsar-build:ubuntu-16.04-pb3` does not have the correct dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org