You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@roller.apache.org by ag...@apache.org on 2005/12/14 17:22:18 UTC

svn commit: r356794 - in /incubator/roller/trunk/src/org/roller/presentation/filters: FeedCacheFilter.java IfModifiedFeedCacheFilter.java WeblogPageCacheFilter.java

Author: agilliland
Date: Wed Dec 14 08:22:12 2005
New Revision: 356794

URL: http://svn.apache.org/viewcvs?rev=356794&view=rev
Log:
making "invalidate()" methods synchronized because they loop through keys and that can cause ConcurrentModificationExceptions.  this should probably be revisiting to see if we can find a better way to do this.


Modified:
    incubator/roller/trunk/src/org/roller/presentation/filters/FeedCacheFilter.java
    incubator/roller/trunk/src/org/roller/presentation/filters/IfModifiedFeedCacheFilter.java
    incubator/roller/trunk/src/org/roller/presentation/filters/WeblogPageCacheFilter.java

Modified: incubator/roller/trunk/src/org/roller/presentation/filters/FeedCacheFilter.java
URL: http://svn.apache.org/viewcvs/incubator/roller/trunk/src/org/roller/presentation/filters/FeedCacheFilter.java?rev=356794&r1=356793&r2=356794&view=diff
==============================================================================
--- incubator/roller/trunk/src/org/roller/presentation/filters/FeedCacheFilter.java (original)
+++ incubator/roller/trunk/src/org/roller/presentation/filters/FeedCacheFilter.java Wed Dec 14 08:22:12 2005
@@ -198,7 +198,7 @@
     /**
      * A weblog has changed.
      */
-    public void invalidate(WebsiteData website) {
+    public synchronized void invalidate(WebsiteData website) {
         
         mLogger.debug("invalidating website = "+website.getHandle());
         

Modified: incubator/roller/trunk/src/org/roller/presentation/filters/IfModifiedFeedCacheFilter.java
URL: http://svn.apache.org/viewcvs/incubator/roller/trunk/src/org/roller/presentation/filters/IfModifiedFeedCacheFilter.java?rev=356794&r1=356793&r2=356794&view=diff
==============================================================================
--- incubator/roller/trunk/src/org/roller/presentation/filters/IfModifiedFeedCacheFilter.java (original)
+++ incubator/roller/trunk/src/org/roller/presentation/filters/IfModifiedFeedCacheFilter.java Wed Dec 14 08:22:12 2005
@@ -204,7 +204,7 @@
     /**
      * A weblog has changed.
      */
-    public void invalidate(WebsiteData website) {
+    public synchronized void invalidate(WebsiteData website) {
         
         mLogger.debug("invalidating website = "+website.getHandle());
         

Modified: incubator/roller/trunk/src/org/roller/presentation/filters/WeblogPageCacheFilter.java
URL: http://svn.apache.org/viewcvs/incubator/roller/trunk/src/org/roller/presentation/filters/WeblogPageCacheFilter.java?rev=356794&r1=356793&r2=356794&view=diff
==============================================================================
--- incubator/roller/trunk/src/org/roller/presentation/filters/WeblogPageCacheFilter.java (original)
+++ incubator/roller/trunk/src/org/roller/presentation/filters/WeblogPageCacheFilter.java Wed Dec 14 08:22:12 2005
@@ -215,7 +215,7 @@
     /**
      * A weblog entry has changed.
      */
-    public void invalidate(WeblogEntryData entry) {
+    public synchronized void invalidate(WeblogEntryData entry) {
         
         mLogger.debug("invalidating entry = "+entry.getAnchor());
         
@@ -254,7 +254,7 @@
     /**
      * A weblog has changed.
      */
-    public void invalidate(WebsiteData website) {
+    public synchronized void invalidate(WebsiteData website) {
         
         mLogger.debug("invalidating website = "+website.getHandle());