You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by andrewor14 <gi...@git.apache.org> on 2014/10/03 01:24:19 UTC

[GitHub] spark pull request: [SPARK-2261] Make event logger use a single fi...

Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/1222#issuecomment-57726091
  
    Hey @vanzin I will take a more detailed look shortly. From a quick glance it seems that now we encode the metadata in the first part of the log file and use a header marker to separate the actual events from this header, is that correct? Meaning, if we want to expose this file for the applications to parse then we'll have to provide some special public API for that. I think that's fine and much better than squeezing everything in the file name. Then the file name just takes the name of the directory, is that right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org