You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/29 08:42:53 UTC
[GitHub] [shardingsphere] zjcnb opened a new issue, #18695: [DistSQL] RDL about READWRITE_SPLITTING RULE need to add `writeDataSourceQueryEnabled` paramter
zjcnb opened a new issue, #18695:
URL: https://github.com/apache/shardingsphere/issues/18695
Hi community,
We recently refactor `readwrite-splitting` feature `API`, you can refer to #18587, #18629.
So, we need to modify `RDL` about `READWRITE_SPLITTING RULE`.
Now CREATE or ALTER Dynamic `READWRITE_SPLITTING RULE` DistSQL are :
// Dynamic
```
CREATE READWRITE_SPLITTING RULE ms_group_1 (
AUTO_AWARE_RESOURCE=group_0
);
```
```
ALTER READWRITE_SPLITTING RULE ms_group_1 (
AUTO_AWARE_RESOURCE=group_1
);
```
Hope to adjust to :
// Dynamic
```
CREATE READWRITE_SPLITTING RULE ms_group_1 (
AUTO_AWARE_RESOURCE=group_0,
WRITE_DATA_SOURCE_QUERY_ENABLED='true'
);
```
```
ALTER READWRITE_SPLITTING RULE ms_group_1 (
AUTO_AWARE_RESOURCE=group_1,
WRITE_DATA_SOURCE_QUERY_ENABLED='false'
);
```
- [ ] Adjust `shardingsphere-readwrite-splitting-distsql-handler` RDLStatement.g4 file.
- [ ] Modify `CreateReadwriteSplittingRuleStatementUpdater.class` and `AlterReadwriteSplittingRuleStatementUpdater.class`.
- [ ] Modify document
1. https://shardingsphere.apache.org/document/current/cn/user-manual/shardingsphere-proxy/distsql/syntax/rdl/rule-definition/readwrite-splitting/
- [ ] Fix shardingsphere-integration-test module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb closed issue #18695: [DistSQL] Need to add `writeDataSourceQueryEnabled` paramter about RDL READWRITE_SPLITTING RULE
Posted by GitBox <gi...@apache.org>.
zjcnb closed issue #18695: [DistSQL] Need to add `writeDataSourceQueryEnabled` paramter about RDL READWRITE_SPLITTING RULE
URL: https://github.com/apache/shardingsphere/issues/18695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on issue #18695: [DistSQL] Need to add `writeDataSourceQueryEnabled` paramter about RDL READWRITE_SPLITTING RULE
Posted by GitBox <gi...@apache.org>.
zjcnb commented on issue #18695:
URL: https://github.com/apache/shardingsphere/issues/18695#issuecomment-1169712120
> I want to try.
Nice, assigned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o commented on issue #18695: [DistSQL] Need to add `writeDataSourceQueryEnabled` paramter about RDL READWRITE_SPLITTING RULE
Posted by GitBox <gi...@apache.org>.
yx9o commented on issue #18695:
URL: https://github.com/apache/shardingsphere/issues/18695#issuecomment-1169823940
@zjcnb Hi, in dynamic syntax, is WRITE_DATA_SOURCE_QUERY_ENABLED required or optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o commented on issue #18695: [DistSQL] Need to add `writeDataSourceQueryEnabled` paramter about RDL READWRITE_SPLITTING RULE
Posted by GitBox <gi...@apache.org>.
yx9o commented on issue #18695:
URL: https://github.com/apache/shardingsphere/issues/18695#issuecomment-1169710575
I want to try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb commented on issue #18695: [DistSQL] Need to add `writeDataSourceQueryEnabled` paramter about RDL READWRITE_SPLITTING RULE
Posted by GitBox <gi...@apache.org>.
zjcnb commented on issue #18695:
URL: https://github.com/apache/shardingsphere/issues/18695#issuecomment-1169825309
> @zjcnb Hi, in dynamic syntax, is WRITE_DATA_SOURCE_QUERY_ENABLED required or optional?
It 's optional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 commented on issue #18695: [DistSQL] Need to add `writeDataSourceQueryEnabled` paramter about RDL READWRITE_SPLITTING RULE
Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 commented on issue #18695:
URL: https://github.com/apache/shardingsphere/issues/18695#issuecomment-1442804700
Ref : https://github.com/apache/shardingsphere/issues/18587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org