[GitHub] [doris] yiguolei commented on a diff in pull request #21381: [Enhancement](inverted index) make InvertedIndexReader shared_from_this

["yiguolei (via GitHub)" <gi...@apache.org>]

yiguolei commented on code in PR #21381:
URL: https://github.com/apache/doris/pull/21381#discussion_r1248356618


##########
be/src/olap/rowset/segment_v2/inverted_index_reader.h:
##########
@@ -64,7 +64,7 @@ enum class InvertedIndexReaderType {
     BKD = 2,
 };
 
-class InvertedIndexReader {

Review Comment:
   If you enable share from this. Then I think you has to add macro ENABLE_FACTORY_CREATOR to disable explicit new . 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org